Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70913

Backpacks sortorder is not updated properly

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Before applying the patch

      1. Login as admin.
      2. Access to "Site administration > Badges > Manage backpacks"
      3. Add a new backpack. You can use dummy values for the required form fields (for instance, http://test.cat for both URLs).
      4. Run the following SQL query and check the sortorder column has the same value ("1") for the 2 entries returned.

        SELECT id, backpackweburl, sortorder FROM mdl_badge_external_backpack

      After applying the patch

      1. Apply the patch.
      2. Login as admin and run the upgrade process.
      3. Access to "Site administration > Badges > Manage backpacks"
      4. Add a new backpack. You can use dummy values for the required form fields, different from the previous one (for instance, http://toberemoved.cat for both URLs).
      5. Add a new backpack. You can use dummy values for the required form fields, different from the previous one (for instance, http://otherurl.cat for both URLs).
      6. Remove the backpack created in step #4 (http://toberemoved.cat).
      7. Add a new backpack. You can use dummy values for the required form fields, different from the previous one (for instance, http://lasturl.cat for both URLs).
      8. Run the following SQL query and check the sortorder column has a different value of each field now (the one with lower id should have 1, the one you created before applying the patch should contain 2, the one you created in step #5 should have 4 and the latest one you created should contain 5).

        SELECT id, backpackweburl, sortorder FROM mdl_badge_external_backpack

      9. Check the backpacks are displayed following the previous sortorder column in page "Manage backpacks" (lower sortorder rows should be displayed first).
      10. Go to "Site administration > Badges > Backpack settings".
      11. Check the backpacks in "Active external backpack" are displayed following the sortorder column (lower sortorder rows should be displayed first in that list).

       

      Show
      Before applying the patch Login as admin. Access to "Site administration > Badges > Manage backpacks" Add a new backpack. You can use dummy values for the required form fields (for instance, http://test.cat  for both URLs). Run the following SQL query and  check the sortorder column has the same value ("1") for the 2 entries returned. SELECT id, backpackweburl, sortorder FROM mdl_badge_external_backpack After applying the patch Apply the patch. Login as admin and run the upgrade process. Access to "Site administration > Badges > Manage backpacks" Add a new backpack. You can use dummy values for the required form fields, different from the previous one (for instance, http://toberemoved.cat  for both URLs). Add a new backpack. You can use dummy values for the required form fields, different from the previous one (for instance, http://otherurl.cat  for both URLs). Remove the backpack created in step #4 ( http://toberemoved.cat ). Add a new backpack. You can use dummy values for the required form fields, different from the previous one (for instance, http://lasturl.cat  for both URLs). Run the following SQL query and  check the sortorder column has a different value of each field now (the one with lower id should have 1, the one you created before applying the patch should contain 2, the one you created in step #5 should have 4 and the latest one you created should contain 5). SELECT id, backpackweburl, sortorder FROM mdl_badge_external_backpack Check the backpacks are displayed following the previous sortorder column in page "Manage backpacks" (lower sortorder rows should be displayed first). Go to "Site administration > Badges > Backpack settings". Check the backpacks in "Active external backpack" are displayed following the sortorder column (lower sortorder rows should be displayed first in that list).  
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-70913-310
    • Pull 3.11 Branch:
      MDL-70913-311
    • Pull Master Branch:
      MDL-70913-master
    • Sprint:
      Moppies Kanban

      Description

      The "sortorder" field in badge_external_backpack table is not updated as expected. Steps to reproduce:

      1. Access to Manage backpacks
      2. Create a backpack with any value (you can use, for instance, http://google.cat in both URL fields).
      3. Check the value for the "sortorder" field in {badge_external_backpack} table.

      Expected result

      The sortorder is higher than the max(sortorder) field.

      Current result

      The sortorder is exactly the count(sortorder) field.

       

      Besides, external backpacks in "Manage backpack" site administration page should be ordered by this sortorder field.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sarjona Sara Arjona (@sarjona)
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Peer reviewer:
              Amaia Anabitarte
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Yuliya Bozhko, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Mar/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 50 minutes
                  3h 50m