Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70931

XMLDB editor produces install.xml files without EOL at the EOF

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as the site admin
      2. Install the attached plugin tool_xmldbeol.zip
      3. Make sure that the web server process has write access to all directories and their subdirectories in your Moodle installation.
      4. Go to Site administration > Development > XMLDB editor
      5. Locate the admin/tool/xmldbeol/db line
      6. Click "Create" action
      7. TEST: Check that the file is created with correct end of line at the last line. This can be done e.g.:
        • running
          cat -e admin/tool/xmldbeol/db/install.xml
          on Unix-line environments and making sure that the shell prompt starts at the new line.
        • or running
          hexdump tool/xmldbeol/db/install.xml
          and making sure that it shows "0a" as the last byte of the file
      8. Click "Load" and then "Edit" actions on the line.
      9. Edit the comment field and click "Change" button
      10. Click "Save" action
      11. TEST: Check again that the file has correct end of line at the last line.
      Show
      Log in as the site admin Install the attached plugin tool_xmldbeol.zip Make sure that the web server process has write access to all directories and their subdirectories in your Moodle installation. Go to Site administration > Development > XMLDB editor Locate the admin/tool/xmldbeol/db line Click "Create" action TEST : Check that the file is created with correct end of line at the last line. This can be done e.g.: running cat -e admin/tool/xmldbeol/db/install.xml on Unix-line environments and making sure that the shell prompt starts at the new line. or running hexdump tool/xmldbeol/db/install.xml and making sure that it shows "0a" as the last byte of the file Click "Load" and then "Edit" actions on the line. Edit the comment field and click "Change" button Click "Save" action TEST : Check again that the file has correct end of line at the last line.
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
      MDL-70931-39-xmldbeol
    • Pull 3.10 Branch:
      MDL-70931-310-xmldbeol
    • Pull 3.11 Branch:
      MDL-70931-311-xmldbeol
    • Pull Master Branch:
      MDL-70931-master-xmldbeol

      Description

      As noticed by Sam Marshall in MDLSITE-6397, XMLDB editor produces install.xml files with missing end-of-line at the end-of-file.

      As a result, generated install.xml files do not follow Moodle's own guidelines discussed in that issue.

        Attachments

          Activity

            People

            Assignee:
            mudrd8mz David Mudrák (@mudrd8mz)
            Reporter:
            mudrd8mz David Mudrák (@mudrd8mz)
            Peer reviewer:
            Tim Hunt Tim Hunt
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            Sujith Haridasan Sujith Haridasan
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/Mar/21

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 50 minutes
                1h 50m