Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70943

mod_workshop formatpeergrade lang string is empty in Arabic

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • None
    • 3.9.4
    • Language, Workshop
    • MOODLE_39_STABLE

      When grading a workshop activity with language set to Arabic, unweighted grades (rendered by the formatpeergrade string) in the "Grades received" and "Grades given" column of the Workshop grades report will not appear. This is because the formatpeergrade string is empty. To reproduce:

      • Create a course with a workshop activity
      • Enroll two users in the course
      • Have each user make a submission
      • Allocate the submissions
      • Move to the assessment phase

      At this point, the issue is already visible. The "Grades received" and "Grades given" columns in the table should look as follows:

      However, if the language is switched to Arabic, the table shows the following:

      Note that the text indicating the assignment grades is not rendered. This is clearer if at this point you

      • Edit the assessment form by adding a description
      • Have the users grade each other's submissions

      Now it will actually show grades in this spot (in English). That looks like this:

      But again, if we switch to Arabic, we see that these grades do not show up:

      Alternatively, switch the language to Arabic, add the following code to line 328 of lib/classes/string_manager_standard.php, and reload the page:

      if ($component == 'workshop') {        
          echo "<pre>".htmlentities(print_r($string, true))."</pre>";     
          die();        
      }
      

      You can then find the following:

       

      ...
       
      [formataggregatedgradeover] => <del>{$a->grade}</del><br /><ins>{$a->over}</ins>
       
      [formatpeergrade] =>
       
      [formatpeergradeover] => <span class="grade">{$a->grade}</span> <span class="gradinggrade">(<del>{$a->gradinggrade}</del> / <ins>{$a->gradinggradeover}</ins>)</span>
       
      ...
      

       

       

       

       

       

            tsala Helen Foster
            bryce.yoder Bryce Yoder
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.