Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70971

Exception thrown in whole forum grading if rubric/grading guide is not set up

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9.4
    • Fix Version/s: None
    • Component/s: Forum
    • Affected Branches:
      MOODLE_39_STABLE

      Description

      When using whole forum grading with a rubric or grading guide that is not set up, the following exception is thrown:

      Exception - Call to a member function get_controller() on null
      Stack trace:
      Error code: generalexceptionmessage
      line 147 of \grade\grading\form\rubric\classes\grades\grader\gradingpanel\external\fetch.php: Error thrown
      line 131 of \grade\grading\form\rubric\classes\grades\grader\gradingpanel\external\fetch.php: call to gradingform_rubric\grades\grader\gradingpanel\external\fetch::get_fetch_data()
      line 261 of \lib\externallib.php: call to gradingform_rubric\grades\grader\gradingpanel\external\fetch::execute()
      line 81 of \lib\ajax\service.php: call to external_api::call_external_function()

      Steps to reproduce:

      1. Create a forum and a post to grade.
      2. Open the forum and Edit Settings > Whole forum grading > Grading method > Rubric
      3. The Advanced grading page appears. Note the alert at the bottom: "Please note: the advanced grading form is not ready at the moment. Simple grading method will be used until the form has a valid status."
      4. Return to the forum and click the "Grade users" button.
      5. The above exception appears.

      According to the note on the Advanded grading page, the rubric should default back to the Simple grading method if it is not set up, but that doesn't appear to happen. At the very least, a proper error message should appear informing the user to adjust their grading method before proceeding with whole forum grading.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            maccmax Max MacCluer
            Participants:
            Component watchers:
            Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            6 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated: