Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.11
Affects Version/s: 3.11
Component/s: General
Labels:
- ci

Affected Branches:
MOODLE_311_STABLE
Fixed Branches:
MOODLE_311_STABLE
Epic Link:
Prepare Moodle for PHP 8.0
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull Main Branch:
~~MDL-71011~~
Pull Main Diff URL:
https://github.com/stronk7/moodle/compare/MDL-71011~3...MDL-71011
Testing Instructions:
Hide

Verify that all the Travis/GHA runs are passing.

Verify that the runs listed here are also passing:

PHP 7.3 - MySQL (311_STABLE): https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/3478/

PHP 7.4 - MariaDB (master): https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/3481/

PHP 7.3 - PostgreSQL (311_STABLE): https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/3479/

PHP 7.4 - SQL*Server (master): https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/3482/

PHP 7.3 - Oracle (311_STABLE): https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/3480/

Verify that the runs listed here, no matter that are NOT passing (there are still many other PHP 8.0 errors) don't show any error related with ADOdb. Basically search for "adodb" in the job -> console output -> view as plain text

PHP 8.0 - Oracle (311_STABLE): https://ci.moodle.org/view/Testing/job/DEV.80%20-%20PHP%208.0%20PHPUnit%20-%20311_STABLE/23/

PHP 8.0 - Oracle (master): https://ci.moodle.org/view/Testing/job/DEV.80%20-%20PHP%208.0%20PHPUnit%20-%20master/24/
Show
Verify that all the Travis/GHA runs are passing. Verify that the runs listed here are also passing: PHP 7.3 - MySQL (311_STABLE): https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/3478/ PHP 7.4 - MariaDB (master): https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/3481/ PHP 7.3 - PostgreSQL (311_STABLE): https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/3479/ PHP 7.4 - SQL*Server (master): https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/3482/ PHP 7.3 - Oracle (311_STABLE): https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/3480/ Verify that the runs listed here, no matter that are NOT passing (there are still many other PHP 8.0 errors) don't show any error related with ADOdb. Basically search for "adodb" in the job -> console output -> view as plain text PHP 8.0 - Oracle (311_STABLE): https://ci.moodle.org/view/Testing/job/DEV.80%20-%20PHP%208.0%20PHPUnit%20-%20311_STABLE/23/ PHP 8.0 - Oracle (master): https://ci.moodle.org/view/Testing/job/DEV.80%20-%20PHP%208.0%20PHPUnit%20-%20master/24/

See https://php.watch/versions/8.0/final-private-function#final-private
There is one occurrence in ADOdb third party library:

lib/adodb/drivers/adodb-oci8po.inc.php: final private function extractBinds($sql,$inputarr)

https://github.com/ADOdb/ADOdb/blob/master/drivers/adodb-oci8po.inc.php#L98 - it is not fixed in the last version

has been marked as being related by

MDL-70898 PHP 8.0: Private methods cannot be final as they are never overridden by other classes

Closed

will help resolve

MDL-51928 Deprecate ADODB MySQL driver - it calls functions that no longer exist in PHP7

Closed

MDL-70191 Review third party libraries for new versions (3.11 release)

Closed

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Amaia Anabitarte

Peer reviewer:: Mihail Geshoski

Integrator:: Sara Arjona (@sarjona)

Tester:: CiBoT

Participants:: Amaia Anabitarte, CiBoT, Eloy Lafuente (stronk7), Mihail Geshoski, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 26/Feb/21 11:10 PM

Updated:: 18/Nov/22 9:05 PM

Resolved:: 16/Apr/21 11:34 PM

Estimated:

Remaining:

Logged:

2h 35m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify