[MDL-71015] Repositories to follow get file timeout - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Open
Priority: Minor
Resolution: Unresolved
Affects Version/s: 3.9.4, 3.10.1, 3.11, 4.0
Fix Version/s: None
Component/s: Repositories
Labels:
- patch
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Pull from Repository:
https://github.com/montypanday/moodle
Pull 3.11 Branch:
MDL-71015-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...montypanday:MDL-71015-311
Pull Master Branch:
MDL-71015-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...montypanday:MDL-71015-master
Difficulty:
Easy
Testing Instructions:

Hide

Try uploading a file from OneDrive repository of size greater than 400MB, it is not a file size limitation but the time it takes to download the file.

Currently, the upload fails with error message that file cannot be read.

Where a timeout does occur, the error message should be that download failed, system should through the correct exception.

Administrator should be able to increase the Get File Timeout in Common repository settings and resolve the timeout issue.

Please note that other server/php settings are required to allow file uploads, have request timeouts greater than the timeout you are testing with.

Show
Try uploading a file from OneDrive repository of size greater than 400MB, it is not a file size limitation but the time it takes to download the file. Currently, the upload fails with error message that file cannot be read. Where a timeout does occur, the error message should be that download failed, system should through the correct exception. Administrator should be able to increase the Get File Timeout in Common repository settings and resolve the timeout issue. Please note that other server/php settings are required to allow file uploads, have request timeouts greater than the timeout you are testing with.

Description

Google Docs and OneDrive repository have fixed timeout settings.

Steps to reproduce.

Set "Get file timeout" to any number say 60 seconds under Site Administration > Plugins > Repositories > Common Repository settings. This settings is currently not being used in all instances.
Try uploading a file greater than 400MB using OneDrive Repository. There is no relation to file size. File should be large enough to cause the timeout.

Expectation

Changing the "Get File Timeout" in shared repository settings allows to increase the timeout and users able to upload bigger files.
Even when timeout does occur, get_file function should adequately check for result.

Actually happens

Changing the "Get File Timeout" settings does not change the behaviour as OneDrive and GoogleDocs don't follow the setting.
Even when a timeout does occur, it shows an ambiguous message "Cannot read file. Either the file does not exist or there is a permission problem". OneDrive and GoogleDocs repositories only check for truthiness of result and non empty error string qualifies for a successful download

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

core_googledocs_timeouts.patch
0.8 kB
22/Nov/22 2:48 PM
core_onedrive_timeouts.patch
2 kB
22/Nov/22 2:48 PM

Activity

People

Assignee:: Unassigned

Reporter:: Monty Panday

Participants:: Andrei Bautu, CiBoT, Mihail Geshoski, Monty Panday, Sujith Haridasan

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 01/Mar/21 11:36 AM

Updated:: 22/Nov/22 2:54 PM

Time Tracking

Estimated:

30m

Remaining:

25m

Logged: