Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71015

Repositories to follow get file timeout

    XMLWordPrintable

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 3.9.4, 3.10.1, 3.11, 4.0
    • None
    • Repositories
    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • MDL-71015-311
    • MDL-71015-master
    • Easy
    • Hide

      Try uploading a file from OneDrive repository of size greater than 400MB, it is not a file size limitation but the time it takes to download the file.

      Currently, the upload fails with error message that file cannot be read.

      Where a timeout does occur, the error message should be that download failed, system should through the correct exception.

      Administrator should be able to increase the Get File Timeout in Common repository settings and resolve the timeout issue.

      Please note that other server/php settings are required to allow file uploads, have request timeouts greater than the timeout you are testing with.

      Show
      Try uploading a file from OneDrive repository of size greater than 400MB, it is not a file size limitation but the time it takes to download the file. Currently, the upload fails with error message that file cannot be read. Where a timeout does occur, the error message should be that download failed, system should through the correct exception. Administrator should be able to increase the Get File Timeout in Common repository settings and resolve the timeout issue. Please note that other server/php settings are required to allow file uploads, have request timeouts greater than the timeout you are testing with.

    Description

      Google Docs and OneDrive repository have fixed timeout settings. 

       

      Steps to reproduce.

      1. Set "Get file timeout" to any number say 60 seconds under Site Administration > Plugins > Repositories > Common Repository settings. This settings is currently not being used in all instances.
      2. Try uploading a file greater than 400MB using OneDrive Repository. There is no relation to file size. File should be large enough to cause the timeout.

       

      Expectation

      1. Changing the "Get File Timeout" in shared repository settings allows to increase the timeout and users able to upload bigger files.
      2. Even when timeout does occur, get_file function should adequately check for result.

       

      Actually happens

      1. Changing the "Get File Timeout" settings does not change the behaviour as OneDrive and GoogleDocs don't follow the setting.
      2. Even when a timeout does occur, it shows an ambiguous message "Cannot read file. Either the file does not exist or there is a permission problem". OneDrive and GoogleDocs repositories only check for truthiness of result and non empty error string qualifies for a successful download

      Attachments

        Activity

          People

            Unassigned Unassigned
            montypanday Monty Panday
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - 30 minutes
                30m
                Remaining:
                Time Spent - 5 minutes Remaining Estimate - 25 minutes
                25m
                Logged:
                Time Spent - 5 minutes Remaining Estimate - 25 minutes
                5m