Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71017

Add the ability to configure OAuth2 services for login only; add login display name

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Go to the Site administration>Server>OAuth 2 services
      2. Click on Google button from 'Create a new service' on the bottom.
      3. Type 'clientid' on Client ID field and 'clientsecret' on Client secret field.
      4. Set 'This service will be used' to 'Login page and internal services'
      5. Set 'Name displayed on the login page' to 'My custom Google service'
      6. Click on Save changes
      7. Click on Microsoft button from 'Create a new service' on the bottom.
      8. Type 'clientid' on Client ID field and 'clientsecret' on Client secret field.
      9. Set 'This service will be used' to 'Login page only'
      10. Click on Save changes
      11. Click on Facebook button from 'Create a new service' on the bottom.
      12. Type 'clientid' on Client ID field and 'clientsecret' on Client secret field.
      13. Set 'This service will be used' to 'Internal services only' and make sure that when this option is changed the fields related to the login are not displayed
      14. Click on Save changes
      15. Make sure we have 3 services created.
      16. Make sure that Google service has a green check icon on the login colum, a green check icon on the services column and shows 'My custom Google service' on the 'Display as' column.
      17. Make sure that Microsoft service has a green check icon on the Login column and a red cross icon on the Services column.
      18. Make sure that Facebook service has a red cross icon on the Login column and a green check icon on the Services column.
      19. Go to Site Administration>Plugins>Authentication>Manage authentication and enable OAuth 2 plugin clicking on the 'eye' icon.
      20. Logout and go to login page
      21. Make sure you can only see buttons for Google and Microsoft services (Not Facebook) and that the Google service shows 'My custom Google service' next to the icon, which is the custom display name we set before.
      22. Login and go to Site administration>Plugins>Manage repositories
      23. Add a "Microsoft OneDrive" repository changing the dropdown next to it to 'Enabled and visible'
      24. Make sure the 'OAuth 2 service' selector shows Google and Facebook, but does not show Microsoft
      Show
      Go to the Site administration>Server>OAuth 2 services Click on Google button from 'Create a new service' on the bottom. Type 'clientid' on Client ID field and 'clientsecret' on Client secret field. Set 'This service will be used' to 'Login page and internal services' Set 'Name displayed on the login page' to 'My custom Google service' Click on Save changes Click on Microsoft button from 'Create a new service' on the bottom. Type 'clientid' on Client ID field and 'clientsecret' on Client secret field. Set 'This service will be used' to 'Login page only' Click on Save changes Click on Facebook button from 'Create a new service' on the bottom. Type 'clientid' on Client ID field and 'clientsecret' on Client secret field. Set 'This service will be used' to 'Internal services only' and make sure that when this option is changed the fields related to the login are not displayed Click on Save changes Make sure we have 3 services created. Make sure that Google service has a green check icon on the login colum, a green check icon on the services column and shows 'My custom Google service' on the 'Display as' column. Make sure that Microsoft service has a green check icon on the Login column and a red cross icon on the Services column. Make sure that Facebook service has a red cross icon on the Login column and a green check icon on the Services column. Go to Site Administration>Plugins>Authentication>Manage authentication and enable OAuth 2 plugin clicking on the 'eye' icon. Logout and go to login page Make sure you can only see buttons for Google and Microsoft services (Not Facebook) and that the Google service shows 'My custom Google service' next to the icon, which is the custom display name we set before. Login and go to Site administration>Plugins>Manage repositories Add a "Microsoft OneDrive" repository changing the dropdown next to it to 'Enabled and visible' Make sure the 'OAuth 2 service' selector shows Google and Facebook, but does not show Microsoft
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE
    • Fixed Branches:
      MOODLE_311_STABLE
    • Pull 3.11 Branch:
      MDL-71017-311-2
    • Pull Master Branch:
      MDL-71017-master-2

      Description

      Currently when you configure OAuth2 services you can specify whether they are available for login. However it is not possible to specify that they are available ONLY for login.

      As a result the list of services in the repositories, for example, is very big and contains a lot of services that should not be there

      Another thing we would like to suggest is to add a "Display name" - how the issuer is displayed on the login page.

        Attachments

        1. 1.png
          1.png
          63 kB
        2. 2.png
          2.png
          73 kB
        3. activitymodulesadmin.png
          activitymodulesadmin.png
          40 kB
        4. MDL-71017.jpg
          MDL-71017.jpg
          45 kB
        5. misconfigured.svg
          1 kB

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Paul Holden Paul Holden
              Integrator:
              Jun Pataleta Jun Pataleta
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 days, 6 hours, 30 minutes
                  4d 6h 30m