Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71018

Move admin tool plugin styles to boost

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Waiting for integration review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.11
    • Fix Version/s: None
    • Component/s: Themes
    • Testing Instructions:
      Hide

      Please test these changes on both theme Classic and Boost. Use 2 Moodle instances to compare the results from the changes in this patch. One Moodle instance (instance A) should be the latest master without the changes in this patch, the other should have this patch (Instance B). 

      Then install your favourite RTL language, for example arab or hebrew. And run the tests again.

      Capability overview styles

      1. Navigate to Site Administration > Users > Permissions > Capability overview
      2. Select all capabilities
      3. Select all roles
      4. Check the style of the permissions table. Verify you see no styling differences between instance A and instance B

      Dataprivacy registry

      1. Navigate to Site Administration > Users > Privacy and policies > Data registry
      2. Verify the tree starting with “site” in the left area is scrollable
      3. Verify there is some space between the buttons “Set defaults” and “Edit”. It is okay if the space it a bit less on instance B compared to A.

      Health center

      1. There is no need to compare the styles of instance A and B for this issue. The styling has been changed totally
      2. Go to the URL /admin/tool/health/ in Moodle
      3. If you do not see any health issues disable cron on your server and try again 24h later
      4. Verify you can see the health issue(s) displayed in alert boxes with an action button like the screenshot below.

      Plugin installer

      1. Configure your config.php and add $CFG->config_php_settings['alternativeaddonsrepositoryurl'] = ‘http://test.com
      2. Navigate to Site Administration > Plugins > Install plugins
      3. Verify the “Install plugins from the Moodle plugins directory” button is centred on the page

      Compatencies & Learning Plans

      1. Navigate to Site Administration > Competencies > Import competency framework
      2. Upload the file ‘competencies.csv’ and confirm the defaults
      3. If all is successful you should see the CCSS.Math framework
      4. Try navigating through the list of competencies and verify it is clear to see which item is selected when clicked
      5. It is okay if the styling differences between instance A and instance B are a bit different, as long as the selected item is clearly visible.
      6. Navigate to Site Administration > Competencies > Learning plan templates
      7. Click the “Add a new learning plan template” button
      8. Name it Math and Save changes
      9. Click the “Add competencies to learning plan template” button
      10. From the CCSS.Math framework select CCSS.Math.practice
      11. Navigate to Site Administration > Competencies > Learning plan templates
      12. Click the link “Math”
      13. Verify you see no styling differences between instance A and instance B.

      User tours

      1. Navigate to Site Administration > Appearance > User tours
      2. On Instance B, verify the “Create a new tour”, “Import tour” and “Tour repository” button backgrounds darken on hover
      3. Click the “Import tour” button (note the buttons are a bit smaller now which is okay)
      4. Upload the attached “add_quiz_tour.json” file
      5. Save changes
      6. Add a quiz activity to a course, on the quiz edit for you should see a new tour. If you don’t see it click the “Reset user tour on this page” link in the page footer
      7. Click next untill the end of the Tour
      8. Verify you see no styling differences between instance A and instance B.

      File types

      1. Navigate to Site Administration > Server > File types
      2. On the first item on the list click the delete icon
      3. Confirm the deletion
      4. Check the styling of the hidden extension. Verify you see no styling differences between instance A and instance B. The spacing between the icons and the extension name is a bit different which is okay.

      Message inbound

      1. Navigate to Site Administration > Server > Email > Message handlers
      2. Verify you see only some styling differences between instance A and instance B. The classnames in instance B are now in text colour instead of grey (for accessibility) which is okay

      Scheduled tasks

      1. Navigate to Site Administration > Server > Tasks > Scheduled tasks
      2. Verify you see only some styling differences between instance A and instance B. The classnames in instance B are now in text colour instead of grey (for accessibility) which is okay

      Template library

      1. Navigate to Site Administration > Development > Template library
      2. Verify the only difference between instance A and instance B is the border around the rendered template

      Acceptance testing styles

      1. Navigate to Site Administration > Development > Acceptance testing
      2. Check the styling of the boxes with testing information. Verify you see no styling differences between instance A and instance B

      Test changes to the anchor offset css

      1. Navigate to a course that has more than 10 sections
      2. In the navdrawer click on a section name
      3. Verify the page jumps to the correct section and that the section heading is visible just underneath the navbar
      Show
      Please test these changes on both theme Classic and Boost. Use 2 Moodle instances to compare the results from the changes in this patch. One Moodle instance (instance A) should be the latest master without the changes in this patch, the other should have this patch (Instance B).  Then install your favourite RTL language, for example arab or hebrew. And run the tests again. Capability overview styles Navigate to Site Administration > Users > Permissions > Capability overview Select all capabilities Select all roles Check the style of the permissions table. Verify you see no styling differences between instance A and instance B Dataprivacy registry Navigate to Site Administration > Users > Privacy and policies > Data registry Verify the tree starting with “site” in the left area is scrollable Verify there is some space between the buttons “Set defaults” and “Edit”. It is okay if the space it a bit less on instance B compared to A. Health center There is no need to compare the styles of instance A and B for this issue. The styling has been changed totally Go to the URL /admin/tool/health/ in Moodle If you do not see any health issues disable cron on your server and try again 24h later Verify you can see the health issue(s) displayed in alert boxes with an action button like the screenshot below. Plugin installer Configure your config.php and add $CFG->config_php_settings ['alternativeaddonsrepositoryurl'] = ‘ http://test.com ’ Navigate to Site Administration > Plugins > Install plugins Verify the “Install plugins from the Moodle plugins directory” button is centred on the page Compatencies & Learning Plans Navigate to Site Administration > Competencies > Import competency framework Upload the file ‘competencies.csv’ and confirm the defaults If all is successful you should see the CCSS.Math framework Try navigating through the list of competencies and verify it is clear to see which item is selected when clicked It is okay if the styling differences between instance A and instance B are a bit different, as long as the selected item is clearly visible. Navigate to Site Administration > Competencies > Learning plan templates Click the “Add a new learning plan template” button Name it Math and Save changes Click the “Add competencies to learning plan template” button From the CCSS.Math framework select CCSS.Math.practice Navigate to Site Administration > Competencies > Learning plan templates Click the link “Math” Verify you see no styling differences between instance A and instance B. User tours Navigate to Site Administration > Appearance > User tours On Instance B, verify the “Create a new tour”, “Import tour” and “Tour repository” button backgrounds darken on hover Click the “Import tour” button (note the buttons are a bit smaller now which is okay) Upload the attached “add_quiz_tour.json” file Save changes Add a quiz activity to a course, on the quiz edit for you should see a new tour. If you don’t see it click the “Reset user tour on this page” link in the page footer Click next untill the end of the Tour Verify you see no styling differences between instance A and instance B. File types Navigate to Site Administration > Server > File types On the first item on the list click the delete icon Confirm the deletion Check the styling of the hidden extension. Verify you see no styling differences between instance A and instance B. The spacing between the icons and the extension name is a bit different which is okay. Message inbound Navigate to Site Administration > Server > Email > Message handlers Verify you see only some styling differences between instance A and instance B. The classnames in instance B are now in text colour instead of grey (for accessibility) which is okay Scheduled tasks Navigate to Site Administration > Server > Tasks > Scheduled tasks Verify you see only some styling differences between instance A and instance B. The classnames in instance B are now in text colour instead of grey (for accessibility) which is okay Template library Navigate to Site Administration > Development > Template library Verify the only difference between instance A and instance B is the border around the rendered template Acceptance testing styles Navigate to Site Administration > Development > Acceptance testing Check the styling of the boxes with testing information. Verify you see no styling differences between instance A and instance B Test changes to the anchor offset css Navigate to a course that has more than 10 sections In the navdrawer click on a section name Verify the page jumps to the correct section and that the section heading is visible just underneath the navbar
    • Affected Branches:
      MOODLE_311_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-71018-master

      Description

      As part of the MDL-69459 this issue moves the css from plugins found in admin/tools to the boost theme.

        Attachments

        1. add_quiz_tour.json
          9 kB
        2. competencies.csv
          269 kB
        3. Health center.png
          Health center.png
          379 kB
        4. Screenshot from 2021-06-03 09-00-41.png
          Screenshot from 2021-06-03 09-00-41.png
          48 kB

          Issue Links

            Activity

              People

              Assignee:
              basbrands Bas Brands
              Reporter:
              basbrands Bas Brands
              Peer reviewer:
              Peter Dias Peter Dias
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 7 hours
                  2d 7h