Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71087

File picker: Focus lost after 'Create folder'

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test on all supported browsers and both in Boost and Classic.

      Testing Instructions for "Create folder"

      • Go into any course, turn editing on, and add a 'File' resource.
      • In the 'Select files' dialog, click the 'Create folder' icon (second from left)
      • Click on "Cancel" button or ESC

           Expected: The keyboard focus still on the create folder icon.

      • In the 'Select files' dialog, click the 'Create folder' icon (second from left)
      • Press Tab twice, type in a folder name e.g. 'test', and press Return to create the folder (the folder is created and the dialog disappears)

            Expected: The keyboard focus still on the create folder icon.

      • Press Tab again
        Expected: The focus should be sensible in "Select files" area.

      Testing Instructions for "Delete" icon

      • Go into any course, turn editing on, and add a 'File' resource.
      • In the 'Select files' dialog, upload two or more files
      • Click on "Display folder with files details" (the second icon from the right)
      • Click on "Delete" icon without select any file or folder
      • Click on "OK" button or ESC
        Expected: The keyboard focus still on the "Delete" icon.
      • Check on a file/folder to delete
      • Click on "Delete" icon
      • Click on "OK" or "Cancel" button or ESC
        Expected: The keyboard focus still on the "Delete" icon.

      In case have one file/or one folder which be deleted.

      • Press Tab again
        Expected: The focus should be sensible in "Select files" area.
      Show
      Test on all supported browsers and both in Boost and Classic. Testing Instructions for "Create folder" Go into any course, turn editing on, and add a 'File' resource. In the 'Select files' dialog, click the 'Create folder' icon (second from left) Click on "Cancel" button or ESC      Expected: The keyboard focus still on the create folder icon. In the 'Select files' dialog, click the 'Create folder' icon (second from left) Press Tab twice, type in a folder name e.g. 'test', and press Return to create the folder (the folder is created and the dialog disappears)       Expected: The keyboard focus still on the create folder icon. Press Tab again Expected: The focus should be sensible in "Select files" area. Testing Instructions for "Delete" icon Go into any course, turn editing on, and add a 'File' resource. In the 'Select files' dialog, upload two or more files Click on "Display folder with files details" (the second icon from the right) Click on "Delete" icon without select any file or folder Click on "OK" button or ESC Expected: The keyboard focus still on the "Delete" icon. Check on a file/folder to delete Click on "Delete" icon Click on "OK" or "Cancel" button or ESC Expected: The keyboard focus still on the "Delete" icon. In case have one file/or one folder which be deleted. Press Tab again Expected: The focus should be sensible in "Select files" area.
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-71087-310
    • Pull 3.11 Branch:
      MDL-71087-311
    • Pull Master Branch:
      MDL-71087-master

      Description

      To reproduce:

      • Go into any course, turn editing on, and add a 'File' resource.
      • In the 'Select files' dialog, click the 'Create folder' icon (second from left)
      • Press Tab twice, type in a folder name e.g. 'test', and press Return to create the folder (the folder is created and the dialog disappears)
      • Press Tab again

      Expected: The focus should be somewhere sensible, e.g. on the newly created folder or still on the create folder icon.
      Actual: Focus is lost entirely and tab starts from the beginning of the page

      Note: This can be reproduced e.g. on Mount Orange demo site at this URL: https://school.moodledemo.net/course/modedit.php?add=resource&type=&course=27&section=0&return=0&sr=0

      One of our (Open University) developers will work on this issue, I'm not assigning to them because I don't know which yet.

        Attachments

        1. MDL-71087.jpg
          29 kB
          Anna Carissa Sadia

          Activity

            People

            Assignee:
            thinhpham83 Thinh Pham Tien
            Reporter:
            quen Sam Marshall
            Peer reviewer:
            Sam Marshall Sam Marshall
            Integrator:
            Víctor Déniz Falcón Víctor Déniz Falcón
            Tester:
            Anna Carissa Sadia Anna Carissa Sadia
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/May/21

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 15 minutes
                2h 15m