Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71144

Deprecate the *_get_completion_state() callbacks

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Sprint:
      Internationals - 3.11 Sprint 9

      Description

      With the activity_custom_completion base class being implemented by activity modules supporting custom completion rules, it is time to deprecate these callbacks as they won't be used anymore.

      A possible approach to do the deprecation:

      1. Add a debugging message that these callbacks are now being deprecated in completion_info::internal_get_state()
      2. Move these callbacks to the plugin's deprecatedlib.php. E.g. in assign, move to mod/assign/deprecatedlib.php. Make sure that deprecatedlib.php is included in the plugin's lib.php
      3. Add the related PHPDoc block tags (e.g. @deprecated, @todo, @see) to the *_get_completion_state() callbacks.
      4. Note the deprecation of these callbacks in upgrade.txt

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rezaie9 Shamim Rezaie
              Reporter:
              jpataleta Jun Pataleta
              Peer reviewer:
              Michael Hawkins
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 2 hours, 35 minutes
                  2d 2h 35m