Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71149

Update upgrade_stale_php_files_present() before 3.11 release

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.11
    • 3.11, 4.0
    • Installation
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE
    • Hide

      Note: TARGET for this issue are (2 because we are under parallel dev):

      1. MOODLE_311_STABLE
      2. master

      (meaning testing must be done twice, once for each TARGET)

      web

      1. Create/check out a 3.10.x site. For example: 

        git checkout v3.10.0

      2. Install the 3.10 site.
      3. Check out the TARGET branch 

        git checkout TARGET

      4. Create any of the following files that are being detected by the patch. (e.g. on Linux, use the "touch" command):
        • customfield/edit.php 

          touch customfield/edit.php

        • message/defaultoutputs.php 

          touch message/defaultoutputs.php

        • ...
      5. Open your Moodle instance on your browser.
      6. Log in as admin and proceed with the upgrade.
      7. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      8. Delete the touched file(s) in point 4.
      9. Click "Reload".
      10. Verify that the upgrade now proceeds ok.

      cli

      1. Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.
      Show
      Note: TARGET for this issue are (2 because we are under parallel dev): MOODLE_311_STABLE master (meaning testing must be done twice, once for each TARGET) web Create/check out a 3.10.x site. For example: git checkout v3.10.0 Install the 3.10 site. Check out the TARGET branch git checkout TARGET Create any of the following files that are being detected by the patch. (e.g. on Linux, use the " touch " command): customfield/edit.php touch customfield/edit.php message/defaultoutputs.php touch message/defaultoutputs.php ... Open your Moodle instance on your browser. Log in as admin and proceed with the upgrade. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file(s) in point 4. Click " Reload ". Verify that the upgrade now proceeds ok. cli Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.

      Simply verify we have a number (4-5) of files for the next major release. They all must be files deleted since last stable version and current master (311_STABLE this time, we are under parallel development period).

      git diff --name-status MOODLE_XX_STABLE..master | grep ^D

      Note that it's better not to pick any plugin file that maybe reinstalled manually (exception being forum files because that plugin is mandatory).

        1. warning.png
          warning.png
          25 kB

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Paul Holden Paul Holden
            Andrew Lyons Andrew Lyons
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            13 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 40 minutes
                1h 40m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.