Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71178

Grade activity completion criteria marks activity as complete when no grades is awarded

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a course. Make sure completion tracking is enabled.
      2. Enrol some users
      3. Add an assignment to the course. Set"Completion tracking" to "Student can manually mark the activity as completed". Save the changes.
      4. Open a new browser tab and go to the activity completion report at http://YOURMOODLE/report/progress/index.php?course=COURSEID
      5. Ensure none of the completion checkboxes for the assignment is ticked.
      6. Back on the assignment's tab, edit the assignment's settings and change "Completion tracking" to "Show activity as complete when conditions are met" and tick "Student must receive a grade to complete this activity". Save the changes.
      7. Reload the Activity completion report tab.
      8. Confirm that the completion checkboxes for the assignment remain unticked.
      Show
      Create a course. Make sure completion tracking is enabled. Enrol some users Add an assignment to the course. Set" Completion tracking " to " Student can manually mark the activity as completed ". Save the changes. Open a new browser tab and go to the activity completion report at http://YOURMOODLE/report/progress/index.php?course=COURSEID Ensure none of the completion checkboxes for the assignment is ticked. Back on the assignment's tab, edit the assignment's settings and change " Completion tracking " to " Show activity as complete when conditions are met " and tick " Student must receive a grade to complete this activity ". Save the changes. Reload the Activity completion report tab. Confirm that the completion checkboxes for the assignment remain unticked.
    • Affected Branches:
      MOODLE_311_STABLE
    • Fixed Branches:
      MOODLE_311_STABLE
    • Pull 3.11 Branch:
      MDL-71178-311
    • Pull Master Branch:
      MDL-71178-master
    • Story Points:
      0
    • Sprint:
      Internationals - 3.11 Sprint 9

      Description

      There is a regression in Moodle 3.11 which allows to mark activity as completed when conditions are not met. Here are steps to reproduce it:

      1. Create a course
      2. Add assignment to a course
      3. Enroll some users
      4. Enable completion tracking in course settings, save changes
      5. In assignment settings set 'Student can manually mark the activity as completed' and save changes
      6. Go to activity completion report at http://YOURMOODLE/report/progress/index.php?course=COURSEID
      7. Ensure no students are marked as completed assignment
      8. Go to assignment setting page again and change completion tracking to 'Show activity as complete when conditions are met' and tick 'Student must receive a grade to complete this activity'. Save changes
      9. Go to activity completion report at http://YOURMOODLE/report/progress/index.php?course=COURSEID
      10. All students in a course will be marked as completed assignment though no one has received any grades

      This affects 3.11 and master branches. Older Moodle versions are fine

        Attachments

        1. MDL-71178.jpg
          MDL-71178.jpg
          28 kB
        2. test.webm
          3.28 MB

          Issue Links

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              ilyatregubov Ilya Tregubov
              Peer reviewer:
              Peter Dias Peter Dias
              Integrator:
              Víctor Déniz Falcón Víctor Déniz Falcón
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 30 minutes
                  4h 30m