[MDL-71182] Revert latest calendar/data request changes (revert MDL-67494) - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.9.6, 3.10.2
Fix Version/s: 3.9.6, 3.10.3
Component/s: Calendar
Labels:

Affected Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
git://github.com/lameze/moodle.git
Pull 3.9 Branch:
~~MDL-71182~~-39-2
Pull 3.9 Diff URL:
https://github.com/lameze/moodle/compare/86f6671fe6...MDL-71182-39-2
Pull 3.11 Branch:
~~MDL-71182~~-311-2
Pull 3.11 Diff URL:
https://github.com/lameze/moodle/compare/7fb15daff2...MDL-71182-311-2
Pull Master Branch:
~~MDL-71182~~-master-2
Pull Master Diff URL:
https://github.com/lameze/moodle/compare/3cd0ad32bc...MDL-71182-master-2
Testing Instructions:
Hide

Test 1. Changing category event userid field to zero should not throw errors

This test needs to ensure changing the userid of a category event to 0 does not throw any errors.

Log in as admin and go to calendar.

Create a category event.

Look on the event table.

Change the userid of that category event to 0.

Reload the calendar.

Make sure you don't see any errors.
Show
Test 1. Changing category event userid field to zero should not throw errors This test needs to ensure changing the userid of a category event to 0 does not throw any errors. Log in as admin and go to calendar. Create a category event. Look on the event table. Change the userid of that category event to 0. Reload the calendar. Make sure you don't see any errors.

Sprint:
Internationals - 3.11 Sprint 9

Description

The upgrade step added by ~~MDL-67494~~ has a wrong upgrade step and needs to be reverted.

The branch must include, the revert commit and the commit to add missing logic for category events in get_context() in the calendar API:

MDL-67494 calendar: add logic for category events in get_context

Otherwise any category event with userid set to 0 will show an error message.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

screenshot-1.png
94 kB
24/Mar/21 4:05 PM

Issue Links

has been marked as being related by

MDL-67494 Course/activity calendar events are deleted when the teacher who created them requests their data to be deleted

Closed

will help resolve

MDL-71156 Upgrade step from MDL-67494 corrupts calendar events

Closed

Activity

People

Assignee:: Simey Lameze

Reporter:: Simey Lameze

Integrator:: Andrew Lyons

Tester:: Janelle Barcega

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Janelle Barcega, Simey Lameze, ToBiC

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 10 Start watching this issue

Dates

Created:: 24/Mar/21 7:34 AM

Updated:: 24/Mar/21 11:14 PM

Resolved:: 24/Mar/21 11:14 PM

Fix Release Date:: 25/Mar/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

5h 2m

Details

Test 1. Changing category event userid field to zero should not throw errors

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking