Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71188

"Show the number of correct responses once the question has finished" checkbox should be in a fieldset

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 3.9.6, 3.10.3
    • Questions
    • MOODLE_310_STABLE, MOODLE_39_STABLE
    • MDL-71188-master
    • Hide
      1. On your terminal, go to "question/type" folder
      2. Clone the qtype_oumultiresponse plugin:

        git clone https://github.com/moodleou/moodle-qtype_oumultiresponse.git oumultiresponse

      3. Set up Behat.

        php admin/tool/behat/cli/init.php

      4. Run the test:

        php admin/tool/behat/cli/run.php --name="Preview a question and submit a partially correct response and has partially correct feedback number."

      5. Confirm that the test passes and you don't get a failure due to the following:

        Field matching locator "Show the number of correct responses once the question has finished" not found.

      Show
      On your terminal, go to "question/type" folder Clone the qtype_oumultiresponse plugin: git clone https://github.com/moodleou/moodle-qtype_oumultiresponse.git oumultiresponse Set up Behat. php admin/tool/behat/cli/init.php Run the test: php admin/tool/behat/cli/run.php --name="Preview a question and submit a partially correct response and has partially correct feedback number." Confirm that the test passes and you don't get a failure due to the following: Field matching locator "Show the number of correct responses once the question has finished" not found.

      The changes from MDL-70288 removed the duplicated label for checkboxes by setting the text parameter as the checkbox's description when a non-empty label parameter is set.

      However, some checkboxes which have both label and text parameters may need to be reevaluated and better be put in fieldsets.

      An example of this is the "Show the number of correct responses once the question has finished" checkbox in edit_question_form.php. "Options" is now its label and "Show the number of correct responses once the question has finished" is now the checkbox's description.

      In this case, it is more appropriate for this checkbox to be put inside a fieldset, with "Options" as the fieldset legend, and the "Show the number of correct responses once the question has finished" text as the checkbox's label.

            jpataleta Jun Pataleta
            jpataleta Jun Pataleta
            Tim Hunt Tim Hunt
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 40 minutes
                40m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.