Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71203

Wiki search form improvement

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9.7
    • Fix Version/s: None
    • Component/s: Wiki (2.x)
    • Labels:
    • Testing Instructions:
      Hide
      1. Navigate to Site administration / Appearance / Themes / Boost
      2. Select "Advanced settings" tab
      3. Type "$enable-rounded: true;" into "Raw initial SCSS" setting
      4. Save theme settings
      5. Enter wiki
      6. Ensure in the quick search form
        1. the text field suits the user interface
        2. the text field has a height corresponding to the height of the button
        3. the button and the text field are combined into a group and there is no space between them
        4. the top left and bottom left corners of the button do not have rounded corners
      Show
      Navigate to Site administration / Appearance / Themes / Boost Select "Advanced settings" tab Type "$enable-rounded: true;" into "Raw initial SCSS" setting Save theme settings Enter wiki Ensure in the quick search form the text field suits the user interface the text field has a height corresponding to the height of the button the button and the text field are combined into a group and there is no space between them the top left and bottom left corners of the button do not have rounded corners
    • Affected Branches:
      MOODLE_39_STABLE
    • Pull 3.9 Branch:
      MDL-71203-wiki_quick_search_improvement

      Description

      In Moodle 3.9 the style of wiki search form differs from the style of surrounding user interface elements. While other elements benefit from using bootstrap classes, wiki search form does not.

      We made some improvements to the code. The patch file attached.

      Improvements made:

      • According to suggestion to use mustache templates given here https://docs.moodle.org/dev/Templates we implemented mustache template for wiki search form.
      • Wiki search form has its renderable class now.
      • We used bootstrap classes in the template. Like in search form in forum module. The search form suits the user interface better.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              андрейусков Андрей Усков
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 minutes
                  5m