Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71252

Avoid showing the 'Mark as done' button on the course page

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Initial setup

      1. Create a course with the following data:
        • Enable completion tracking: Yes.
        • Show completion conditions: No.
      2. Create a teacher account and a student account.
      3. Enrol teacher and student.

      Label

      1. Log in as a teacher.
      2. Create a Label resource and add it to the course with the following data:
        • Name: Moodle.
        • Completion tracking: Students can manually mark the activity as completed.
      1. Verify that there is a Mark as done button below the Label on the course home page.
      2. Log in as a student.
      3. Go to the created course.
      4. Verify that there is a Mark as done button below the Label on the course home page.

      URL

      1. Log in as a teacher.
      2. Create a URL resource and add it to the course with the following data:
        • Name: Moodle.
        • External URL: https://moodle.org/
        • Display: New Window or Open or In pop-up.
        • Completion tracking: Students can manually mark the activity as completed.
      3. Verify that there is a Mark as done button below the created URL on the course home page.
      4. Log in as a student.
      5. Go to the created course.
      6. Verify that there is a Mark as done button below the created URL on the course home page.
      7. Turn editing mode Edit the display mode of the URL resource and set it to another value that is not in the display modes mentioned above.
      8. Confirm that the "Mark as done" button is not shown for the URL resource on the course home page for these display modes.

      File

      1. Log in as a teacher.
      2. Create a File resource and add it to the course with the following data:
        • Name: File.
        • Display: Force Download or New Window or Open or In pop-up.
        • Completion tracking: Students can manually mark the activity as completed.
      3. Verify that there is a Mark as done button below the created File on the course home page.
      4. Log in as a student.
      5. Go to the created course.
      6. Verify that there is a Mark as done button below the created File on the course home page.
      7. Turn editing mode Edit the display mode of the file resource and set it to another value that is not in the display modes mentioned above.
      8. Confirm that the "Mark as done" button is not shown for the URL resource on the course home page for these display modes.

      Page

      1. Log in as a teacher.
      2. Create a Page resource and add it to the course with the following data:
        • Name: Page.
        • Page content: Test.
        • Completion tracking: Students can manually mark the activity as completed.
      3. Verify that there is no Mark as done button below the created Page on the course home page.
      4. Log in as a student.
      5. Go to the created course
      6. Verify that there is no Mark as done button below the created Page on the course home page.

      Assignment

      1. Log in as a teacher.
      2. Create an Assignment activity and add it to the course with the following data:
        • Name: Assignment.
        • Completion tracking: Students can manually mark the activity as completed.
      3. Verify that there is no Mark as done button below the created Assignment on the course home page.
      4. Log in as a student.
      5. Go to the created course
      6. Verify that there is no Mark as done button below the created Assignment on the course home page.

      Show completion conditions - On

      1. Log in as a teacher.
      2. Edit the created course and set Show completion conditions to Yes.
      3. Verify that the Mark as done button is displayed in the course homepage for all of the activities that were created above.\

       

      Show
      Initial setup Create a course with the following data: Enable completion tracking : Yes. Show completion conditions : No. Create a teacher account and a student account. Enrol teacher and student. Label Log in as a teacher. Create a Label resource and add it to the course with the following data: Name : Moodle. Completion tracking : Students can manually mark the activity as completed. Verify that there is a  Mark as done button below the Label on the course home page. Log in as a student. Go to the created course. Verify that there is a  Mark as done button below the Label on the course home page. URL Log in as a teacher. Create a URL resource and add it to the course with the following data: Name : Moodle. External URL : https://moodle.org/ Display : New Window or Open or In pop-up. Completion tracking : Students can manually mark the activity as completed. Verify that there is a  Mark as done button below the created URL on the course home page. Log in as a student. Go to the created course. Verify that there is a  Mark as done button below the created URL on the course home page. Turn editing mode Edit the display mode of the URL resource and set it to another value that is not in the display modes mentioned above. Confirm that the "Mark as done" button is not shown for the URL resource on the course home page for these display modes. File Log in as a teacher. Create a File resource and add it to the course with the following data: Name : File. Display : Force Download or New Window or Open or In pop-up. Completion tracking : Students can manually mark the activity as completed. Verify that there is a  Mark as done button below the created File on the course home page. Log in as a student. Go to the created course. Verify that there is a  Mark as done button below the created File on the course home page. Turn editing mode Edit the display mode of the file resource and set it to another value that is not in the display modes mentioned above. Confirm that the "Mark as done" button is not shown for the URL resource on the course home page for these display modes. Page Log in as a teacher. Create a Page resource and add it to the course with the following data: Name : Page. Page content: Test. Completion tracking : Students can manually mark the activity as completed. Verify that there is no  Mark as done button below the created Page on the course home page. Log in as a student. Go to the created course Verify that there is no  Mark as done button below the created Page on the course home page. Assignment Log in as a teacher. Create an Assignment activity and add it to the course with the following data: Name : Assignment. Completion tracking : Students can manually mark the activity as completed. Verify that there is no  Mark as done button below the created Assignment on the course home page. Log in as a student. Go to the created course Verify that there is no  Mark as done button below the created Assignment on the course home page. Show completion conditions - On Log in as a teacher. Edit the created course and set  Show completion conditions to Yes. Verify that the  Mark as done button is displayed in the course homepage for all of the activities that were created above.\  
    • Affected Branches:
      MOODLE_311_STABLE
    • Fixed Branches:
      MOODLE_311_STABLE
    • Pull 3.11 Branch:
      MDL-71252-311
    • Pull Master Branch:
      MDL-71252-master

      Description

      Based on feedback from the MUA (as mentioned in a comment in MDL-70469) and in the discussion Re: Student activity completion in Moodle 3.11, when completion conditions are not shown on the course page, it would be best if the 'Mark as done' button is also not shown.

      The activity page is the natural place to mark an activity as done, and not showing it on the course page would mean that students can't mark activities as complete without even looking at them.

      That said, there are a few edge cases where it will not be possible to mark activities as done on the activity/resource page, namely:

      • File resource set to force download, open, in pop-up, new window
      • URL set to display open, in pop-up, new window
      • Label

      I think it would be a shame though to show the 'Mark as done' button for all activities on the course page just because of these few edge cases.

      Possible solutions are:

      1. Only show the 'Mark as done' button on the course page for Label, File and URL resources.
      2. Only show the 'Mark as done' button on the course page for Label and when File or URL are set to force download/open/in pop-up/new window.

      Edited to add steps to reproduce:

      1. Create a course with 'Enable completion tracking' set to Yes and 'Show completion conditions' set to No.
      2. Add some activities and resources to the course with completion tracking set to 'Students can manually mark the activity as completed'.
      3. Add some activities and resources to the course with completion tracking set to 'Show activity as complete when conditions are met'.
      4. View the course page.

      Expected result: Activity completion conditions are not shown on the course page.

      Actual result: Automatic completion conditions are not shown, but a 'Mark as done' button is shown for activities and resources with manual completion.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              huongn@moodle.com Huong Nguyen
              Reporter:
              tsala Helen Foster
              Peer reviewer:
              Simey Lameze Simey Lameze
              Integrator:
              Jun Pataleta Jun Pataleta
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              12 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 days, 1 hour, 22 minutes
                  4d 1h 22m