Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71288

Activity completion fallback for third party plugins

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      We'll need:

      1. Completion enabled at site level
      2. A course with completion enabled and few students enrolled.
      3. Create two choice activities with the following settings
        Setting Choice 1 Choice 2
        Completion tracking Show activity as complete when conditions are met Show activity as complete when conditions are met
        Require view Yes Yes
        Show as complete when user makes a choice Yes No
      4. Create a folder activity with the following settings
        Completion tracking Show activity as complete when conditions are met
        Require view Yes
      5. Install one or both of the third-party plugins that support custom completion but don't have the custom completion class yet.
      6. Add these third-party activities to the course.
      7. On the edit form for these activities, under the Activity completion tab, set Completion tracking to Show activity as complete when conditions are met and select all completion criteria for these activities.

      Testing - Core activities

      1. Log in as a student and go to the course.
      2. Confirm that choice and folder activities' completion conditions are displayed individually.
      3. Confirm that you don't see "To do: Complete activity" on them.

      Testing - Third-party activities with custom completion

      1. Check the third-party activities
      2. Confirm that you see To do: Complete the activity for the third-party activities.
      3. Complete the third-party activities.
      4. Go back to the course page.
      5. Make sure the activity you completed is now flagged Done: Complete the activity
      Show
      Setup We'll need: Completion enabled at site level A course with completion enabled and few students enrolled. Create two choice activities with the following settings Setting Choice 1 Choice 2 Completion tracking Show activity as complete when conditions are met Show activity as complete when conditions are met Require view Yes Yes Show as complete when user makes a choice Yes No Create a folder activity with the following settings Completion tracking Show activity as complete when conditions are met Require view Yes Install one or both of the third-party plugins that support custom completion but don't have the custom completion class yet. mod_questionnaire mod_peerwork Add these third-party activities to the course. On the edit form for these activities, under the Activity completion tab, set Completion tracking to Show activity as complete when conditions are met and select all completion criteria for these activities. Testing - Core activities Log in as a student and go to the course. Confirm that choice and folder activities' completion conditions are displayed individually. Confirm that you don't see " To do: Complete activity " on them. Testing - Third-party activities with custom completion Check the third-party activities Confirm that you see To do: Complete the activity for the third-party activities. Complete the third-party activities. Go back to the course page. Make sure the activity you completed is now flagged Done: Complete the activity
    • Affected Branches:
      MOODLE_311_STABLE
    • Fixed Branches:
      MOODLE_311_STABLE
    • Pull from Repository:
    • Pull 3.11 Branch:
      MDL-71288-311
    • Pull Master Branch:
      MDL-71288-master

      Description

      In MDL-70821, we show badges to indicate if an activity is completed or not. We also show the list of actions a user should perform for an activity with auto-completion to be marked as completed.

      The third-party plugins that are not implemented the new completion details functionality, do not show any indications about if they are completed or not. We should somehow take care of them.

      A proposal is to display some generic label that reflects the activity has completion conditions and indicate when they have been completed. Maybe something like:

      • "To do: complete"
      • "Done: completed"

       

        Attachments

          Activity

            People

            Assignee:
            lameze Simey Lameze
            Reporter:
            rezaie9 Shamim Rezaie
            Peer reviewer:
            Dongsheng Cai Dongsheng Cai
            Integrator:
            Jun Pataleta Jun Pataleta
            Tester:
            Gladys Basiana Gladys Basiana
            Participants:
            Component watchers:
            Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              17/May/21

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 5 hours, 43 minutes
                2d 5h 43m