Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71322

Unnecessary IF

    XMLWordPrintable

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 3.8.8, 3.9.6, 3.10.3
    • None
    • Logging
    • None
    • MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Internationals - 3.11 Sprint 9

    Description

      In login/lib.php has an IF that checks if it's called home.

      if ($urltogo == ($CFG->wwwroot . '/')) {

       

      Within this IF there is another one that validates several other options

      if ($urltogo == $CFG->wwwroot or $urltogo == $CFG->wwwroot.'/' or $urltogo == $CFG->wwwroot.'/index.php') {

       

      but it only arrives at this IF with the clause "$urltogo == $CFG->wwwroot.'/'"

       

      and never with "$urltogo == $CFG->wwwroot" and "$urltogo == $CFG->wwwroot.'/index.php'"

      Attachments

        Activity

          People

            Unassigned Unassigned
            eduardokraus Eduardo Kraus
            David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: