Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71329

MoodleNet profile not being validated properly when linking through the activity chooser

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • MOODLE_310_STABLE
    • MDL-71329-311
    • Hide

      Adapting the instructions from MDLQA-15999

      IP address provided is for example.com

      Requirements:

      1. MoodleNet integration to be enabled
      2. activitychooseractivefooter set to MoodleNet
      3. MoodleNet profile for use in testing, such as @moodleqatester@moodle.net
      4. curlsecurityblockedhosts set to 93.184.216.34

      Test

      1. Log in as a teacher, go to a course and turn editing on.
      2. Click on the 'Add an activity' link then click on the 'or browse for content on MoodleNet' link in the footer.
      3. Verify that the modal window shows a form where you can enter your MoodleNet profile.
      4. Enter an invalid profile e.g. @qwerty and click 'Save and go'.
      5. Verify that you get the response 'There was a problem trying to validate your profile'.
      6. Enter a valid MoodleNet profile and click 'Save and go'.
      7. Once successful (confirmed with a "Looks good!" message and a redirect), go back to your Moodle site.
      8. Go to your profile page and in the 'User details', verify that your MoodleNet profile is correct.
      Show
      Adapting the instructions from MDLQA-15999 IP address provided is for example.com Requirements: MoodleNet integration to be enabled activitychooseractivefooter set to MoodleNet MoodleNet profile for use in testing, such as @moodleqatester@moodle.net curlsecurityblockedhosts set to 93.184.216.34 Test Log in as a teacher, go to a course and turn editing on. Click on the 'Add an activity' link then click on the 'or browse for content on MoodleNet' link in the footer. Verify that the modal window shows a form where you can enter your MoodleNet profile. Enter an invalid profile e.g. @qwerty and click 'Save and go'. Verify that you get the response 'There was a problem trying to validate your profile'. Enter a valid MoodleNet profile and click 'Save and go'. Once successful (confirmed with a "Looks good!" message and a redirect), go back to your Moodle site. Go to your profile page and in the 'User details', verify that your MoodleNet profile is correct.
    • 3
    • QA blitz

    Description

      This issue was identified in MDLQA-15999 and MDLQA-14800 and can be replicated on https://qa.moodledemo.net.

      When linking a MoodleNet profile through the activity chooser, an invalid profile that bypasses the validator can be entered, which later results in generating an invalid url.

      Steps to reproduce:

      Enable MoodleNet integration and activitychooseractivefooter set to MoodleNet in the site administration.

      1. Log in as a teacher, go to a course and turn editing on.
      2. Click on the 'Add an activity' link then click on the 'or browse for content on MoodleNet' link in the footer.
      3. Verify that the modal window shows a form where you can enter your MoodleNet profile.
      4. Enter an invalid profile e.g. @qwerty and click 'Save and go'.

      Expected:

      • The validation would fail stating that an invalid MoodleNet profile was entered.

      Actual:

      Attachments

        Issue Links

          Discovered while testing

          Functional Test - A test of a single Moodle feature MDLQA-15999 CLONE - A teacher can set their MoodleNet profile

          • Minor - Minor loss of function where workaround is possible
          • Passed

          Activity

            People

              mathewmay Mathew May
              Geshoski Mihail Geshoski
              Mihail Geshoski Mihail Geshoski
              Adrian Greeve Adrian Greeve
              Anna Carissa Sadia Anna Carissa Sadia
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/May/21

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 5 minutes
                  1d 5m