[MDL-71338] Wrong content type when exporting user tours - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.6
Fix Version/s: 3.9.7, 3.10.4
Component/s: User Tours
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
git://github.com/paulholden/moodle.git
Pull 3.9 Branch:
~~MDL-71338~~-39
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...paulholden:MDL-71338-39
Pull 3.11 Branch:
~~MDL-71338~~-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...paulholden:MDL-71338-311
Pull Master Branch:
~~MDL-71338~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-71338
Testing Instructions:
Hide

Login as admin

Navigate to Appearance > User tours in site administration

Click Import tour

Upload tour_export_2_1618432513.json and press Save changes

Press User tours in the breadcrumbs to navigate back to the tours listing

For the Dashboard tour you just imported press Export tour

Confirm that your web browser prompts you to download the tour as a JSON file:

Confirm (via web browser developer tools) that the response headers for the downloaded tour contain:

Content-Type: application/json
Show
Login as admin Navigate to Appearance > User tours in site administration Click Import tour Upload tour_export_2_1618432513.json and press Save changes Press User tours in the breadcrumbs to navigate back to the tours listing For the Dashboard tour you just imported press Export tour Confirm that your web browser prompts you to download the tour as a JSON file: Confirm (via web browser developer tools) that the response headers for the downloaded tour contain: Content-Type: application/json

Description

When exporting user tours it has ICS format instead of JSON

Login as administrator
Navigate to Site administration -> Appearance -> User Tours
Click on Tour repository
Download one of the tours
Navigate to Site administration -> Appearance -> User Tours
Click on Import tour and upload the downloaded tour
Add 'Ensure that the newly imported tour works as expected.'
Click on the tour Export tour icon for the tour you just imported or some existing tour.
The exported file will have ics extension which is not correct

Looks like bug was from beginning https://github.com/moodle/moodle/blame/511a87f5fc357f18a4c53911f6e6c7f7b526246e/admin/tool/usertours/classes/manager.php#L448

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-71338_Test Passed.PNG
146 kB
15/Apr/21 4:54 PM
MDL-71338-1.png
53 kB
15/Apr/21 4:43 AM
MDL-71338-2.png
56 kB
15/Apr/21 4:43 AM
tour_export_2_1618432513.json
2 kB
15/Apr/21 4:43 AM

Issue Links

Discovered while testing

MDLQA-15894 CLONE - Import and Export user tour

Passed

Activity

People

Assignee:: Paul Holden

Reporter:: Ilya Tregubov

Peer reviewer:: Michael Hawkins

Integrator:: Jake Dallimore

Tester:: Gladys Basiana

Participants:: CiBoT, Gladys Basiana, Ilya Tregubov, Jake Dallimore, Michael Hawkins, Paul Holden

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 14/Apr/21 10:50 PM

Updated:: 04/May/21 8:29 PM

Resolved:: 16/Apr/21 11:31 PM

Fix Release Date:: 10/May/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

3h 12m