Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71365

Fix ignorefiles (eslint, stylelint...) recently became out of correct ordering

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.9.7, 3.10.4
    • 3.11, 4.0
    • Libraries, Themes
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_310_STABLE, MOODLE_39_STABLE
    • Hide
      1. Remove the .eslintignore and .stylelintignore files.
      2. Install node stuff, normally by running:
        1. nvm use
        2. npm ci
      3. Run $(npm bin)/grunt ignorefiles
      4. Verify that the new generated .eslintignore and .stylelintignore are 100% the same than the removed ones (can run git diff and git status to see if there is any change).
      5. Verify that CiBoT checks in this issue are green (passed) and don't show any grunt problem.
      6. Verify that the .eslintignore and .stylelintignore files have a LF (\n) at the end of the last line. That can be done by executing cat -e .eslintignore and cat -e . stylelintignore. If the information Shows a $ in the last line of the output (in the "fontawesome" one)... then it's correctly ended.
      Show
      Remove the .eslintignore and .stylelintignore files. Install node stuff, normally by running: nvm use npm ci Run $(npm bin)/grunt ignorefiles Verify that the new generated .eslintignore and .stylelintignore are 100% the same than the removed ones (can run git diff and git status to see if there is any change). Verify that CiBoT checks in this issue are green (passed) and don't show any grunt problem. Verify that the .eslintignore and .stylelintignore files have a LF (\n) at the end of the last line. That can be done by executing cat -e .eslintignore and cat -e . stylelintignore . If the information Shows a $ in the last line of the output (in the "fontawesome" one)... then it's correctly ended.

      Since a couple of days, the grunt job @ integration.moodle.org is failing. (link).

      Also, all CiBoT runs are failing with problems in the very same grunt job. (link).

      Looking to history, it seems that MDL-70311 added some changes to the ignore files... correct ones... but did it out of expected (thirdpartylibs.xml) order. And then, when the jobs run... they detect that the current ignore files (wrongly sorted) are not like the expected ones (sorted ok).

      So this issue is just about to move the unordered line(s) to their correct place (or maybe the thirdpartylibs.xml order), that will make all grunt ignorefiles executions happy.

        1. MDL-71365.jpg
          MDL-71365.jpg
          69 kB

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Andrew Lyons Andrew Lyons
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 50 minutes
                2h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.