Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71365

Fix ignorefiles (eslint, stylelint...) recently became out of correct ordering

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.11, 4.0
    • Fix Version/s: 3.9.7, 3.10.4
    • Component/s: Libraries, Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Remove the .eslintignore and .stylelintignore files.
      2. Install node stuff, normally by running:
        1. nvm use
        2. npm ci
      3. Run $(npm bin)/grunt ignorefiles
      4. Verify that the new generated .eslintignore and .stylelintignore are 100% the same than the removed ones (can run git diff and git status to see if there is any change).
      5. Verify that CiBoT checks in this issue are green (passed) and don't show any grunt problem.
      6. Verify that the .eslintignore and .stylelintignore files have a LF (\n) at the end of the last line. That can be done by executing cat -e .eslintignore and cat -e . stylelintignore. If the information Shows a $ in the last line of the output (in the "fontawesome" one)... then it's correctly ended.
      Show
      Remove the .eslintignore and .stylelintignore files. Install node stuff, normally by running: nvm use npm ci Run $(npm bin)/grunt ignorefiles Verify that the new generated .eslintignore and .stylelintignore are 100% the same than the removed ones (can run git diff and git status to see if there is any change). Verify that CiBoT checks in this issue are green (passed) and don't show any grunt problem. Verify that the .eslintignore and .stylelintignore files have a LF (\n) at the end of the last line. That can be done by executing cat -e .eslintignore and cat -e . stylelintignore . If the information Shows a $ in the last line of the output (in the "fontawesome" one)... then it's correctly ended.
    • Affected Branches:
      MOODLE_311_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-71365_310
    • Pull 3.11 Branch:
      MDL-71365_311
    • Pull Master Branch:

      Description

      Since a couple of days, the grunt job @ integration.moodle.org is failing. (link).

      Also, all CiBoT runs are failing with problems in the very same grunt job. (link).

      Looking to history, it seems that MDL-70311 added some changes to the ignore files... correct ones... but did it out of expected (thirdpartylibs.xml) order. And then, when the jobs run... they detect that the current ignore files (wrongly sorted) are not like the expected ones (sorted ok).

      So this issue is just about to move the unordered line(s) to their correct place (or maybe the thirdpartylibs.xml order), that will make all grunt ignorefiles executions happy.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Andrew Lyons Andrew Lyons
              Integrator:
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 50 minutes
                  2h 50m