Loading...

XML

Word

Printable

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull Main Branch:
~~MDL-71367~~
Pull Main Diff URL:
https://github.com/stronk7/moodle/compare/MDL-71367~1...MDL-71367
Testing Instructions:
Hide

It's enough to get the tests @ ci.moodle.org passing, so let CiBoT to do so.

The windows-travis run below in the issue show how the fix is causing the test to pass ok. If you've a Windows host at hand... just:

run vendor/bin/phpunit --filter core_backup_cleanup_task_testcase

verify the it passes.

If you don't have windows at hand, no worries... a bunch of Windows tests are going to be run to complete the Moodle 3.11 release testing matrix, and for sure we'll know there if this is fixed.
Show
It's enough to get the tests @ ci.moodle.org passing, so let CiBoT to do so. The windows-travis run below in the issue show how the fix is causing the test to pass ok. If you've a Windows host at hand... just: run vendor/bin/phpunit --filter core_backup_cleanup_task_testcase verify the it passes. If you don't have windows at hand, no worries... a bunch of Windows tests are going to be run to complete the Moodle 3.11 release testing matrix , and for sure we'll know there if this is fixed.

Just run a complete phpunit here against Moodle 3.11dev+ and got these 2 new errors:

2) core_backup_cleanup_task_testcase::test_backup_cleanup_task_deletes_records

rmdir(C:\Users\stronk7\moodledata\integration_phpunit/temp/backup): Directory not empty

C:\Users\stronk7\git_moodle\integration\lib\moodlelib.php:9793

C:\Users\stronk7\git_moodle\integration\lib\moodlelib.php:9782

C:\Users\stronk7\git_moodle\integration\lib\testing\classes\util.php:792

C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\util.php:266

C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\advanced_testcase.php:534

C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\advanced_testcase.php:114

3) core_backup_cleanup_task_testcase::test_backup_cleanup_task_deletes_files

unlink(C:\Users\stronk7\moodledata\integration_phpunit/temp/backup/5436f391b55a70cee61f90afd580b101.log): Permission denied

C:\Users\stronk7\git_moodle\integration\lib\moodlelib.php:9784

C:\Users\stronk7\git_moodle\integration\lib\moodlelib.php:9782

C:\Users\stronk7\git_moodle\integration\lib\testing\classes\util.php:792

C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\util.php:266

C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\advanced_testcase.php:534

C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\advanced_testcase.php:100

These problems use to happen when some file has been left unclosed under Windows and that prevents any write/remove operation on them.

Haven't checked what happens in 3.10.x or older, the problems didn't exist on 3.10.0 release but maybe now they do. Please check.

is a regression caused by

MDL-71044 Extend the 'backup_cleanup_task' scheduled task to remove old files

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Sara Arjona (@sarjona)

Estimated:

Not Specified

Remaining:

Logged:

42m