[MDL-71369] form change checker is not applied to admin everywhere - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.6, 3.10.3
Fix Version/s: 3.10.5, 3.11.1
Component/s: Administration
Labels:
- ci

Affected Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull 3.11 Branch:
~~MDL-71369~~-311
Pull 3.11 Diff URL:
https://github.com/andrewnicols/moodle/compare/beefea6bad...MDL-71369-311
Pull Master Branch:
~~MDL-71369~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/efb3d4e7a7...MDL-71369-master
Testing Instructions:
Hide

Admin settings

Log in as admin

Navigate to Site administration -> Plugins -> Activity modules

Refresh the page

Confirm that you weren't shown a warning about form changes

For each of the following, change the value and without clicking off the element, refresh the page:

Frame height

Include role names in parameters

Available display options

Display

Confirm that you were shown a warning about form changes
Note: The Password unmask field type does not currently fully support the Form change checker
That is covered by a separate bug (MDL-71046)
Show
Admin settings Log in as admin Navigate to Site administration -> Plugins -> Activity modules Refresh the page Confirm that you weren't shown a warning about form changes For each of the following, change the value and without clicking off the element, refresh the page: Frame height Include role names in parameters Available display options Display Confirm that you were shown a warning about form changes Note: The Password unmask field type does not currently fully support the Form change checker That is covered by a separate bug ( MDL-71046 )

Description

The change checker works if you visit settings for a single component, but not when you are vieiwn gthe 'category' view.

i.e. it is active on /admin/settings.php but not /admin/category.php.

Attachments

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-71369.jpg
34 kB
10/Jun/21 2:06 PM

Issue Links

blocks

MDL-69918 Rewrite Form Change Checker in ES6

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Simey Lameze

Integrator:: Adrian Greeve

Tester:: Anna Carissa Sadia

Participants:: Adrian Greeve, Andrew Lyons, Anna Carissa Sadia, CiBoT, Dongsheng Cai, Simey Lameze

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 19/Apr/21 9:55 AM

Updated:: 11/Jun/21 2:44 PM

Resolved:: 11/Jun/21 2:44 PM

Fix Release Date:: 12/Jul/21

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

2h 16m