Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71370

showcompletionconditions should not be set when completion is not being tracked for the course

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Setup
      1. Check out a Moodle 3.10 instance. (e.g. git checkout v3.10.0)
      2. Create a fresh install of this moodle instance.
      Upgrade test
      1. Create two courses with the following settings
        • Course 1: Completion tracking enabled
        • Course 2: Completion tracking disabled
      2. Check out the latest version for this instance (e.g. for master, "git checkout master")
      3. Upgrade your site
      4. Go to Administration / Courses / Course default settings
      5. Set "Show completion conditions" to "No". Save the changes.
      6. Edit Course 1
      7. Confirm that the "Show completion conditions" field is set to Yes.
      8. Edit Course 2
      9. Set "Enable completion tracking" to "Yes".
      10. Confirm that the "Show completion conditions" field is set to "No".
      Show
      Setup Check out a Moodle 3.10 instance. (e.g. git checkout v3.10.0 ) Create a fresh install of this moodle instance. Upgrade test Create two courses with the following settings Course 1: Completion tracking enabled Course 2: Completion tracking disabled Check out the latest version for this instance (e.g. for master, " git checkout master ") Upgrade your site Go to Administration / Courses / Course default settings Set " Show completion conditions " to "No". Save the changes. Edit Course 1 Confirm that the " Show completion conditions " field is set to Yes. Edit Course 2 Set " Enable completion tracking " to "Yes". Confirm that the " Show completion conditions " field is set to "No".
    • Affected Branches:
      MOODLE_311_STABLE
    • Fixed Branches:
      MOODLE_311_STABLE
    • Pull 3.11 Branch:
      MDL-71370-311-test
    • Pull Master Branch:
      MDL-71370-master-test

      Description

      When completion tracking is disabled for the course, the Show completion conditions setting should be disabled.

      On the form, it is being hidden when completion tracking is disabled, but somehow it is still being set.

      Perhaps it should work as follows:

      1. showcompletionconditions should be allowed to be null and not set a default value of 1.
      2. On upgrade, we set "showcompletionconditions" to 1 for existing courses with completion tracking.
      3. On course creation/update, when completion is not being tracked for the course:
        1. When creating a course, we should unset "showcompletionconditions" so it is null when it gets registered
        2. When updating a course, we should set "showcompletionconditions" to null.

      So when the course gets edited and Completion tracking is set to "Yes", the "Show completion conditions" select element will display the site defaults setting for "showcompletionconditions".

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              jpataleta Jun Pataleta
              Peer reviewer:
              Dongsheng Cai Dongsheng Cai
              Integrator:
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 45 minutes
                  5h 45m