Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71373

Localize hard coded aria-label strings in table pagination and role manager

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisite
      As an admin install a language pack different to 'English'.
      When testing this do change the language to that different from 'English' one.

      Testing aria-label in table pagination

      1. As trainer, in a course, enrol more than 40 students.
      2. Go to Participants.
      3. Skip to the second page.
      4. Using browser inspector check the 'aria-label' value for Next or/and Previous buttons in the pagination bar. 
      5. Verify the values for 'Previous' and 'Next' are localized.

      Testing aria-label in user tours

      1. As administrator, go to admin/tool/usertours/configure.php and do import a usertour for the dashboard like this one https://archive.moodle.net/mod/data/view.php?d=2&rid=757&filter=1. (Do ignore warning related to blocks removed in the meantime and hence missing language strings).
      2. As student, go to the Dashboard and wait for the user tour to start.
      3. Skip to the second page.
      4. Using browser inspector check the Previous page/Next page/End tour buttons have no superfluous 'aria-label' value and the button still say "Previous", "Next" and "End tour".

      Testing aria-label in role manager

      1. As an admin go to a create a new user and enrol it as manager in a course category.
      2. Go to a course of that category.
      3. Go to 'More...' option in the course cog menu
      4. Go to Users > Other users.
      5. Verify the new user is listed in 'Other users' page.
      6. Click on 'Assign roles'  icon on the right side of the table.
      7. Using browser inspector check the 'aria-label' value for the close icon X in the 'Asign roles' small modal.
      8. Verify the value for 'Close' is localized.

      Show
      Prerequisite As an admin install a language pack different to 'English'. When testing this do change the language to that different from 'English' one. Testing aria-label in table pagination As trainer, in a course, enrol more than 40 students. Go to Participants. Skip to the second page. Using browser inspector check the 'aria-label' value for Next or/and Previous buttons in the pagination bar.  Verify the values for 'Previous' and 'Next' are localized. Testing aria-label in user tours As administrator, go to admin/tool/usertours/configure.php and do import a usertour for the dashboard like this one https://archive.moodle.net/mod/data/view.php?d=2&rid=757&filter=1 . (Do ignore warning related to blocks removed in the meantime and hence missing language strings). As student, go to the Dashboard and wait for the user tour to start. Skip to the second page. Using browser inspector check the Previous page/Next page/End tour buttons have no superfluous 'aria-label' value and the button still say "Previous", "Next" and "End tour". Testing aria-label in role manager As an admin go to a create a new user and enrol it as manager in a course category. Go to a course of that category. Go to 'More...' option in the course cog menu Go to Users > Other users. Verify the new user is listed in 'Other users' page. Click on 'Assign roles'  icon on the right side of the table. Using browser inspector check the 'aria-label' value for the close icon X in the 'Asign roles' small modal. Verify the value for 'Close' is localized.
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE
    • Pull 3.10 Branch:
      MDL-71373-310
    • Pull 3.11 Branch:
      MDL-71373-311
    • Pull Master Branch:
      MDL-71373-master

      Description

      As Tim Hunt reported in MDL-62347 'Previous' and 'Next' aria-labels are hard-coded in paging_bar.mustache

      Steps to reproduce:

      1. As an admin install a language pack different to 'English' and set it up as default language for the site.
      2. Go to any page with a list needs a pagination bar. For example, Participants list for a course with lots of users enrolled or Manage course and categories for sites with lots of courses.
      3. Using browser inspector check the 'aria-label' value for Next or/and Previous buttons in the pagination bar. 
      4. The values are 'Previous' and 'Next' instead of the language you are using.

       

        Attachments

        1. image-2021-04-20-16-56-12-137.png
          image-2021-04-20-16-56-12-137.png
          0.5 kB
        2. image-2021-04-20-17-00-42-806.png
          image-2021-04-20-17-00-42-806.png
          18 kB
        3. MDL-71373_participants.png
          MDL-71373_participants.png
          160 kB
        4. MDL-71373_Test Passed.png
          MDL-71373_Test Passed.png
          114 kB
        5. MDL-71373_usertour.png
          MDL-71373_usertour.png
          70 kB
        6. MDL-71373.png
          MDL-71373.png
          172 kB

          Issue Links

            Activity

              People

              Assignee:
              lucaboesch Luca Bösch
              Reporter:
              amaia Amaia Anabitarte
              Peer reviewer:
              Amaia Anabitarte Amaia Anabitarte
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, David Mudrák (@mudrd8mz), Helen Foster, Víctor Déniz Falcón
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jul/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 15 minutes
                  6h 15m