Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71389

PHP8: Address unittests failures caused by error types / message text changes

    XMLWordPrintable

Details

    Description

      Some error messages in PHP8 changed from notice->warning or from warning->error, some error texts also slightly changed wordings. It made some unittests fail

      This issue:

      1. addresses a change in PHP 8.0 to standardise all type warning messages: https://github.com/php/php-src/pull/5092
      2. addresses a change in PHP 8.0 whereby some notices have been converted to warnings in preparation for deprecation of legacy behaviours (documented at https://www.php.net/manual/en/migration80.incompatible.php)
      3. allows for a change in expected behaviour whereby Mail headers are now consistently wrapped with CRLF instead of LF

      For the change in Mail headers, this change relates to a documented change in PHP, and adoption of the same change in PHPMailer. It is the change to PHPMailer which affects us here.

      Attachments

        Activity

          People

            marina Marina Glancy
            marina Marina Glancy
            Paul Holden Paul Holden
            Andrew Lyons Andrew Lyons
            CiBoT CiBoT
            Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              17/May/21

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 50 minutes
                3h 50m