Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71420

Lower php-sodium requirement down to recommendation

XMLWordPrintable

    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_310_STABLE, MOODLE_35_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Hide

      For moodle 3.5, 3.8, 3.9, 3.10, 3.11, and master.

      1. Install a site.
      2. Go to admin -> server -> environment.
      3. In the drop down select "3.11 upwards"
      4. Verify that the "php extension sodium" says "should be installed and enabled for best results".
      5. Verify that clicking on that message you see some text from Moodle Docs.
      6. Only when the site being tested is < 3.11:
        1. In the drop down select any other, older, version than 3.11
        2. Verify that there isn't any "php extension sodium" element or explanation.
      Show
      For moodle 3.5, 3.8, 3.9, 3.10, 3.11, and master. Install a site. Go to admin -> server -> environment. In the drop down select "3.11 upwards" Verify that the "php extension sodium" says "should be installed and enabled for best results" . Verify that clicking on that message you see some text from Moodle Docs. Only when the site being tested is < 3.11: In the drop down select any other, older, version than 3.11 Verify that there isn't any "php extension sodium" element or explanation.

      This is a followup of MDL-69308 and MDL-70363, were, after some discussions it was agreed to lower the php-sodium extension from requirement to recommendation.

      Also, at the same time, it was agreed to make this a temporal thing and, immediately after next LTS version, make it again a requirement.

      For more information about the discussions and rationale for the changes, please visit the linked issues.

      So, let's:

      • lower the requirement to recommendation in 311 and up.
      • follow the standard deprecation procedure to declare the fallback at lib/classes/encryption.php deprecated and due to be removed for the version after next LTS (that will be, if nothing changes, 4.2). Note that a new issue, in the 4.2 deprecations epic, has been created as part of this issue.
      • note that all the places where the new requirement was added (release notes, dev docs, see need to be amended to show the lowered status).

      Ciao

        1. MDL-71420.png
          MDL-71420.png
          142 kB

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Victor Déniz Falcón Victor Déniz Falcón
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 46 minutes
                2h 46m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.