Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71455

Restored course with completion conditions not shown yet 'Show completion conditions' set to Yes

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test case 1: Backup file from old Moodle version.
      1. On a Moodle 3.10 instance, create a course with activities with completion (e.g. manual, automatic) and availability dates for these activities (e.g. if on assignment, set Allow submission values or due dates.
      2. Back up this course.
      3. On your 311 or master site, set both "Show activity dates" and "Show completion conditions" Site administration > Courses > Course default settings" to "Yes"
      4. Restore the old course backup.
      5. *Confirm *that the restored course displays the activity dates and completion information on the course homepage.
      Test case 2: restore a backup file without show activity dates and show completion conditions settings
      1. go to course default settings: Go to Site administration > Courses > Course default settings
      2. change Show activity dates and Show completion conditions to No
      3. Restore a backup of a qa_accessibility_course.mbz
      4. View the course page and notice that completion conditions are not shown.
      5. View the course edit settings page, activity dates and completion conditions should be No
      Test case 3: restore a backup file with defined show activity dates and show completion conditions settings
      1. Create a course backup from 3.11 with Show activity dates and Show completion conditions to Yes in course settings
      2. go to course default settings: http://localhost:8080/stable_master/admin/settings.php?section=coursesettings
      3. change Show activity dates and Show completion conditions to No
      4. Restore a backup created in the first step
      5. View the course edit settings page, activity dates and completion conditions should be "yes"
      Show
      Test case 1: Backup file from old Moodle version. On a Moodle 3.10 instance, create a course with activities with completion (e.g. manual, automatic) and availability dates for these activities (e.g. if on assignment, set Allow submission values or due dates. Back up this course. On your 311 or master site, set both " Show activity dates " and " Show completion conditions " Site administration > Courses > Course default settings " to " Yes " Restore the old course backup. *Confirm *that the restored course displays the activity dates and completion information on the course homepage. Test case 2: restore a backup file without show activity dates and show completion conditions settings go to course default settings: Go to Site administration > Courses > Course default settings change Show activity dates and Show completion conditions to No Restore a backup of a qa_accessibility_course.mbz View the course page and notice that completion conditions are not shown. View the course edit settings page, activity dates and completion conditions should be No Test case 3: restore a backup file with defined show activity dates and show completion conditions settings Create a course backup from 3.11 with Show activity dates and Show completion conditions to Yes in course settings go to course default settings: http://localhost:8080/stable_master/admin/settings.php?section=coursesettings change Show activity dates and Show completion conditions to No Restore a backup created in the first step View the course edit settings page, activity dates and completion conditions should be "yes"
    • Affected Branches:
      MOODLE_311_STABLE
    • Fixed Branches:
      MOODLE_311_STABLE
    • Pull from Repository:
    • Pull 3.11 Branch:
      MDL-71455-311
    • Pull Master Branch:
      MDL-71455-master

      Description

      As found when restoring a 3.9 backup (attached to MDLQA-16040) on the QA testing site.

      Steps to reproduce:

      1. Restore a backup of a course containing activities with activity completion.
      2. View the course page and notice that completion conditions are not shown.
      3. View the course edit settings page.

      Expected result: 'Show completion conditions' is set to No.

      Actual result: 'Show completion conditions' is set to Yes.

      An alternative fix for this issue would be for a restored course to have completion conditions shown on the course page, then it would make sense that 'Show completion conditions' is set to Yes.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dongsheng Dongsheng Cai
              Reporter:
              tsala Helen Foster
              Peer reviewer:
              Simey Lameze Simey Lameze
              Integrator:
              Jun Pataleta Jun Pataleta
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 46 minutes
                  6h 46m