Grading page converts a submission, but leaves a record in the convert_submissions task queue

Testing the patch and the upgrade script

Before the patch

1. Navigate to Site administration > Server > Tasks > Scheduled tasks.
2. Disable "Prepare submissions for annotation" scheduled task.
3. Create an assignment with File submissions and Annotate PDF enabled.
4. As a student submit a submission with a file.
5. Check the mdl_assignfeedback_editpdf_queue table to have a record for the submission.

   mysql> select * from mdl_assignfeedback_editpdf_queue;

   +----+--------------+-------------------+----------------------+

   | id | submissionid | submissionattempt | attemptedconversions |

   +----+--------------+-------------------+----------------------+

   | 5 | 6 | 0 | 0 |

   +----+--------------+-------------------+----------------------+

   1 row in set (0.00 sec)

6. As a teacher navigate to the grading page.
7. Confirm, that the submission is converted and displayed.
8. Check the mdl_assignfeedback_editpdf_queue table and confirm, that the record still exists.

   mysql> select * from mdl_assignfeedback_editpdf_queue;

   +----+--------------+-------------------+----------------------+

   | id | submissionid | submissionattempt | attemptedconversions |

   +----+--------------+-------------------+----------------------+

   | 5 | 6 | 0 | 0 |

   +----+--------------+-------------------+----------------------+

   1 row in set (0.00 sec)

After the patch

1. With the patch applied, run the upgrade script.
2. Check the mdl_assignfeedback_editpdf_queue table and confirm, that the record was deleted.

3. mysql> select * from mdl_assignfeedback_editpdf_queue;

   Empty set (0.00 sec)

4. Create new assignment with File submissions and Annotate PDF enabled.
5. As a student submit a submission with a file.
6. Check the mdl_assignfeedback_editpdf_queue table to have a record for the submission.

   mysql> select * from mdl_assignfeedback_editpdf_queue;

   +----+--------------+-------------------+----------------------+

   | id | submissionid | submissionattempt | attemptedconversions |

   +----+--------------+-------------------+----------------------+

   | 6 | 7 | 0 | 0 |

   +----+--------------+-------------------+----------------------+

   1 row in set (0.00 sec)

7. As a teacher navigate to the grading page.
8. Confirm, that the submission is converted and displayed.
9. Check the mdl_assignfeedback_editpdf_queue table and confirm, that the record was deleted.

   mysql> select * from mdl_assignfeedback_editpdf_queue;

   Empty set (0.00 sec)