Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71471

Grading page converts a submission, but leaves a record in the convert_submissions task queue

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing the patch and the upgrade script

      Before the patch

      1. Navigate to Site administration > Server > Tasks > Scheduled tasks.
      2. Disable "Prepare submissions for annotation" scheduled task.
      3. Create an assignment with File submissions and Annotate PDF enabled.
      4. As a student submit a submission with a file.
      5. Check the mdl_assignfeedback_editpdf_queue table to have a record for the submission.

        mysql> select * from mdl_assignfeedback_editpdf_queue;
        +----+--------------+-------------------+----------------------+
        | id | submissionid | submissionattempt | attemptedconversions |
        +----+--------------+-------------------+----------------------+
        |  5 |            6 |                 0 |                    0 |
        +----+--------------+-------------------+----------------------+
        1 row in set (0.00 sec)
        

      6. As a teacher navigate to the grading page.
      7. Confirm, that the submission is converted and displayed.
      8. Check the mdl_assignfeedback_editpdf_queue table and confirm, that the record still exists.

        mysql> select * from mdl_assignfeedback_editpdf_queue;
        +----+--------------+-------------------+----------------------+
        | id | submissionid | submissionattempt | attemptedconversions |
        +----+--------------+-------------------+----------------------+
        |  5 |            6 |                 0 |                    0 |
        +----+--------------+-------------------+----------------------+
        1 row in set (0.00 sec)
        

      After the patch

      1. With the patch applied, run the upgrade script.
      2. Check the mdl_assignfeedback_editpdf_queue table and confirm, that the record was deleted.
      3. mysql> select * from mdl_assignfeedback_editpdf_queue;
        Empty set (0.00 sec)
        

      4. Create new assignment with File submissions and Annotate PDF enabled.
      5. As a student submit a submission with a file.
      6. Check the mdl_assignfeedback_editpdf_queue table to have a record for the submission.

        mysql> select * from mdl_assignfeedback_editpdf_queue;
        +----+--------------+-------------------+----------------------+
        | id | submissionid | submissionattempt | attemptedconversions |
        +----+--------------+-------------------+----------------------+
        |  6 |            7 |                 0 |                    0 |
        +----+--------------+-------------------+----------------------+
        1 row in set (0.00 sec)
        

      7. As a teacher navigate to the grading page.
      8. Confirm, that the submission is converted and displayed.
      9. Check the mdl_assignfeedback_editpdf_queue table and confirm, that the record was deleted.

        mysql> select * from mdl_assignfeedback_editpdf_queue;
        Empty set (0.00 sec)
        

      Show
      Testing the patch and the upgrade script Before the patch Navigate to Site administration > Server > Tasks > Scheduled tasks. Disable "Prepare submissions for annotation" scheduled task. Create an assignment with  File submissions  and  Annotate PDF  enabled. As a student submit a submission with a file. Check the  mdl_assignfeedback_editpdf_queue table to have a record for the submission. mysql> select * from mdl_assignfeedback_editpdf_queue; +----+--------------+-------------------+----------------------+ | id | submissionid | submissionattempt | attemptedconversions | +----+--------------+-------------------+----------------------+ | 5 | 6 | 0 | 0 | +----+--------------+-------------------+----------------------+ 1 row in set ( 0.00 sec) As a teacher navigate to the grading page. Confirm , that the submission is converted and displayed. Check the  mdl_assignfeedback_editpdf_queue table and confirm , that the record still exists. mysql> select * from mdl_assignfeedback_editpdf_queue; +----+--------------+-------------------+----------------------+ | id | submissionid | submissionattempt | attemptedconversions | +----+--------------+-------------------+----------------------+ | 5 | 6 | 0 | 0 | +----+--------------+-------------------+----------------------+ 1 row in set ( 0.00 sec) After the patch With the patch applied, run the upgrade script. Check the  mdl_assignfeedback_editpdf_queue table and confirm , that the record was deleted. mysql> select * from mdl_assignfeedback_editpdf_queue; Empty set ( 0.00 sec) Create new assignment with  File submissions  and  Annotate PDF  enabled. As a student submit a submission with a file. Check the  mdl_assignfeedback_editpdf_queue table to have a record for the submission. mysql> select * from mdl_assignfeedback_editpdf_queue; +----+--------------+-------------------+----------------------+ | id | submissionid | submissionattempt | attemptedconversions | +----+--------------+-------------------+----------------------+ | 6 | 7 | 0 | 0 | +----+--------------+-------------------+----------------------+ 1 row in set ( 0.00 sec) As a teacher navigate to the grading page. Confirm , that the submission is converted and displayed. Check the  mdl_assignfeedback_editpdf_queue table and confirm , that the record was deleted. mysql> select * from mdl_assignfeedback_editpdf_queue; Empty set ( 0.00 sec)
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE
    • Pull from Repository:
    • Pull 3.10 Branch:
      MOODLE_310_MDL-71471_v2
    • Pull 3.11 Branch:
      MOODLE_311_MDL-71471_v2
    • Pull Master Branch:
      master-MDL-71471_v2

      Description

      Steps to replicate:

      1. Disable cron.
      2. Create an assignment with File submissions and Annotate PDF enabled.
      3. As a student submit a submission with a file.
      4. Check the mdl_assignfeedback_editpdf_queue table to have a record for the submission.
      5. As a teacher navigate to the grading page.
      6. Confirm, that the submission is converted and displayed.
      7. Check the mdl_assignfeedback_editpdf_queue table and confirm, that the records still exist.

      This bug has caused the lagging queue, but hasn't been reported by users because eventually all submissions are converted on the fly in teachers' sessions.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mikhailgolenkov Mikhail Golenkov
              Reporter:
              mikhailgolenkov Mikhail Golenkov
              Peer reviewer:
              Dmitrii Metelkin Dmitrii Metelkin
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              3 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jul/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 10 minutes
                  2h 10m