Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71473

Jabber should be removed as a standard notification plugin

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_311_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-71473-master
    • Testing Instructions:
      Hide

      Setup

      The following steps should be run on a Moodle site without the patch. For instance, you can run "git checkout 036800d99debfe61dde45f61292bc5ad44ab7cb0".

      1. Login as admin.
      2. Go to "Site administration > Messaging > Jabber".
      3. Set all the values in the form and save changes. You can use real data, such as xmpp.jp or any invented data (as you prefer).
      4. Access to "Site administration > Messaging > Notification settings".
      5. In the "Personal messages between users" row, select "Online" and "Offline" in the Jabber column.
      6. Go to the user preferences page and access "Notification preferences".
      7. Click the cog in the Jabber column and write down something (for instance, admintest@xmpp.jp).
      8. Check the following SQL query returns 1:

        SELECT count(*) FROM mdl_message_processors WHERE name = 'jabber'
        

      9. Check the following SQL query returns a number greater than zero:

        SELECT count(*) FROM mdl_user_preferences WHERE name like 'message_processor%' or value like '%jabber%'
        

      10. Check the following SQL query returns a number greater than zero:

        SELECT count(*) FROM mdl_config WHERE name like 'jabber%'
        

      11. Check the following SQL query returns a number greater than zero:

        SELECT count(*) FROM mdl_config_plugins WHERE plugin = 'message' AND name like 'jabber%'  

       

      Testing instructions

      1. Apply the patch and run the upgrade process.
      2. Go to "Site administration > Plugins > Plugins overview".
      3. Check "Jabber" doesn't appear in the "Notification plugins" section.
      4. Access to the "Notification settings" page.
      5. Check "Jabber" doesn't appear in the "Notification plugins" list.
      6. Verify that in the "Default notification preferences" table there is no "Jabber" column.
      7. Go to the user preferences page and access "Notification preferences".
      8. Check there is no "Jabber" column.
      9. Access to "Site administration > Development > Third-party libraries".
      10. Check the "XMPPHP" library is not displayed.
      11. Check the following SQL query returns 0:

        SELECT count(*) FROM mdl_message_processors WHERE name = 'jabber'
        

      12. Check the following SQL query returns 0:

        SELECT count(*) FROM mdl_user_preferences WHERE name like 'message_processor%' or value like '%jabber%'
        

      13. Check the following SQL query returns 0:

        SELECT count(*) FROM mdl_config WHERE name like 'jabber%'
        

      14. Check the following SQL query returns 0:

        SELECT count(*) FROM mdl_config_plugins WHERE plugin = 'message' AND name like 'jabber%'  

       
       
       

      Show
      Setup The following steps should be run on a Moodle site without the patch. For instance, you can run "git checkout 036800d99debfe61dde45f61292bc5ad44ab7cb0". Login as admin. Go to "Site administration > Messaging > Jabber". Set all the values in the form and save changes. You can use real data, such as xmpp.jp or any invented data (as you prefer). Access to "Site administration > Messaging > Notification settings". In the "Personal messages between users" row, select "Online" and "Offline" in the Jabber column. Go to the user preferences page and access "Notification preferences". Click the cog in the Jabber column and write down something (for instance, admintest@xmpp.jp). Check  the following SQL query returns 1: SELECT count(*) FROM mdl_message_processors WHERE name = 'jabber' Check  the following SQL query returns a number greater than zero: SELECT count(*) FROM mdl_user_preferences WHERE name like 'message_processor%' or value like '%jabber%' Check  the following SQL query returns a number greater than zero: SELECT count(*) FROM mdl_config WHERE name like 'jabber%' Check  the following SQL query returns a number greater than zero: SELECT count(*) FROM mdl_config_plugins WHERE plugin = 'message' AND name like 'jabber%'      Testing instructions Apply the patch and run the upgrade process. Go to "Site administration > Plugins > Plugins overview". Check "Jabber" doesn't appear in the "Notification plugins" section. Access to the "Notification settings" page. Check "Jabber" doesn't appear in the "Notification plugins" list. Verify that in the "Default notification preferences" table there is no "Jabber" column. Go to the user preferences page and access "Notification preferences". Check there is no "Jabber" column. Access to "Site administration > Development > Third-party libraries". Check the "XMPPHP" library is not displayed. Check  the following SQL query returns 0: SELECT count(*) FROM mdl_message_processors WHERE name = 'jabber' Check  the following SQL query returns 0: SELECT count(*) FROM mdl_user_preferences WHERE name like 'message_processor%' or value like '%jabber%' Check  the following SQL query returns 0: SELECT count(*) FROM mdl_config WHERE name like 'jabber%' Check  the following SQL query returns 0: SELECT count(*) FROM mdl_config_plugins WHERE plugin = 'message' AND name like 'jabber%'         
    • Sprint:
      Moppies Kanban

      Description

      As commented by David Mudrák (@mudrd8mz) in MDLQA-15580, Jabber is not widely used these days so it would make sense to remove it as a standard notification plugin and add it to the Moodle plugins directory.

        Attachments

        1. MDL-71473_after_Step 10.png
          MDL-71473_after_Step 10.png
          143 kB
        2. MDL-71473_after_Step 11.png
          MDL-71473_after_Step 11.png
          66 kB
        3. MDL-71473_after_Step 12.png
          MDL-71473_after_Step 12.png
          72 kB
        4. MDL-71473_after_Step 13.png
          MDL-71473_after_Step 13.png
          64 kB
        5. MDL-71473_after_Step 14.png
          MDL-71473_after_Step 14.png
          71 kB
        6. MDL-71473_after_Step 3.png
          MDL-71473_after_Step 3.png
          57 kB
        7. MDL-71473_after_Step 5-6.png
          MDL-71473_after_Step 5-6.png
          112 kB
        8. MDL-71473_after_Step 8.png
          MDL-71473_after_Step 8.png
          77 kB
        9. MDL-71473_before_Step 10.png
          MDL-71473_before_Step 10.png
          64 kB
        10. MDL-71473_before_Step 11.png
          MDL-71473_before_Step 11.png
          66 kB
        11. MDL-71473_before_Step 8.png
          MDL-71473_before_Step 8.png
          64 kB
        12. MDL-71473_before_Step 9.png
          MDL-71473_before_Step 9.png
          67 kB
        13. screenshot-1.png
          screenshot-1.png
          31 kB
        14. screenshot-2.png
          screenshot-2.png
          30 kB

          Issue Links

            Activity

              People

              Assignee:
              sarjona Sara Arjona (@sarjona)
              Reporter:
              tsala Helen Foster
              Peer reviewer:
              David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
              Integrator:
              Jun Pataleta Jun Pataleta
              Tester:
              Angelia Dela Cruz Angelia Dela Cruz
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 20 minutes
                  6h 20m