Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71532

Review illegal whitespace in some tool_brickfield files

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.11, 4.0
    • Fix Version/s: 3.11
    • Component/s: Accessibility toolkit
    • Labels:

      Description

      With MDL-69863 landed, the "illegal whitespace check" job has detected new cases and started to fail.

       current count: 957
      previous count: 889
          best count: 889
      

      That's caused by existing "illegal" (tabs, spaces at end...) whitespace in the following files:

      LICENSE_QUAIL.txt
      classes/local/htmlchecker/common/resources/placeholder.txt
      tests/local/htmlchecker/common/checks/img_alt_is_different_test.php
      tests/local/htmlchecker/common/checks/img_alt_not_empty_in_anchor_test.php
      tests/local/htmlchecker/common/checks/img_has_alt_test.php
      tests/local/htmlchecker/common/checks/img_alt_is_too_long_test.php
      

      As immediate measure, we have added those files as allowed exceptions to the check, so it's back to green.

      https://github.com/moodlehq/moodle-local_ci/commit/523788411e13702617e6e83528a6e33622f06ad0

      No matter of that it would be great to review the cases in the files above and, if possible, fix them. They seem to be mostly .txt and test files and, maybe they are not a requirement and, for example, tabs can be changed to 4 spaces without hurting anything.

      Also, when any of those files are cleaned, it would be great to ping to any integrator, so the exceptions can be removed as much as possible.

      For your consideration.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mchurch Mike Churchward
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Integrator:
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Tester:
              CiBoT CiBoT
              Participants:
              Component watchers:
              Mike Churchward, Karen Holland
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 35 minutes
                  35m