-
Bug
-
Resolution: Fixed
-
Minor
-
3.11
-
MOODLE_311_STABLE
-
MOODLE_311_STABLE
-
The symfony polyfill for mbstring triggers a php lint failure in PHP 7.4
php7.4 -l lib/phpspreadsheet/vendor/symfony/polyfill-mbstring/bootstrap80.php
I understand HQ doesn't run a full lint on the codebase and excludes vendor dirs, but we've been doing that for years in our CI and has been passing for a long time (and passes on all supported versions prior to 3.11)
I see that the phpspreadsheet lib already has other libraries removed as they exist in Moodle, eg:
/vendor/myclabs/ vendor/maennchen/
As mbstring has been required since Moodle 3.9, I think the symfony/polyfill-mbstring should be removed as well - which also fixes the lint issue.
htmlpurifier also already exists in core under lib/htmlpurifier so phpspreadsheet/vendor/ezyyang/htmlpurifier should also be removed.
It would also be interesting to hear if there is a policy for ignoring Lint failures in 3rd party libs included in core?
- is a regression caused by
-
MDL-70314 Upgrade PHPSpreadsheet to 1.16.0
- Closed