[MDL-71539] PHP 8.0: Remove required parameters after optional parameters in Brickfield plugins - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11, 4.0
Fix Version/s: 3.11
Component/s: Accessibility toolkit, Automated functional tests (behat)
Labels:
- ci
- triaged

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Epic Link:
Prepare Moodle for PHP 8.0
Pull from Repository:
https://github.com/brickfield/moodle
Pull 3.11 Branch:
~~MDL-71539~~_311_PHP8optionalparams
Pull 3.11 Diff URL:
https://github.com/brickfield/moodle/commit/f816040530932b6fd3be09075bf441b4f5ba8c5b
Pull Master Branch:
~~MDL-71539~~_master_PHP8optionalparams
Pull Master Diff URL:
https://github.com/brickfield/moodle/commit/3dc209b748eb3233f609492c8aa5f568461858b3
Testing Instructions:

Hide

Run Behat with PHP8.
Verify the Behat steps no longer throw the PHP8 optional param error

Show
Run Behat with PHP8. Verify the Behat steps no longer throw the PHP8 optional param error

Description

In ~~MDL-69863~~ Brickfield Education Labs accessibility toolkit landed. While testing ~~MDL-71390~~, I've seen scenarios in lib/tests/behat/largeforms.feature are failing when they are run with PHP 8.0:

PHP errors found:

Unknown error type: Required parameter $resultstime follows optional parameter $html at moodle/admin/tool/brickfield/classes/accessibility.php: 223

 F---------....................................

--- Failed steps:

001 Scenario: Small form with checkboxes (not using workaround) # lib/tests/behat/largeforms.feature:21

 When I am on the "C1" "Course" page logged in as "admin" # lib/tests/behat/largeforms.feature:15

 PHP errors found:

 Unknown error type: Required parameter $resultstime follows optional parameter $html at admin/tool/brickfield/classes/accessibility.php: 223 (Exception)

As it was done in ~~MDL-70893~~, optional parameters being declared before required are forbidden.

See https://php.watch/versions/8.0#deprecate-required-param-after-optional

Attachments

Issue Links

blocks

MDL-71390 PHP8 does not like our max_input_vars workaround. Proposed solution - set minimum requirement for max_input_vars

Closed

Discovered while testing

MDL-71390 PHP8 does not like our max_input_vars workaround. Proposed solution - set minimum requirement for max_input_vars

Closed

is a regression caused by

MDL-69863 Brickfield Education Labs accessibility toolkit core integration

Closed

Activity

People

Assignee:: Mike Churchward

Reporter:: Sara Arjona (@sarjona)

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: CiBoT, Eloy Lafuente (stronk7), Mike Churchward, Sara Arjona (@sarjona)

Component watchers:: Mike Churchward, Karen Holland

Votes:: 1 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 05/May/21 6:36 PM

Updated:: 07/May/21 11:29 PM

Resolved:: 07/May/21 11:29 PM

Fix Release Date:: 17/May/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

30m