[MDL-71559] User fields: new PROFILE_VISIBLE_TEACHERS constant not supported - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11
Fix Version/s: 3.11.1
Component/s: User management
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_311_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/sammarshallou/moodle.git
Pull 3.11 Branch:
~~MDL-71559~~-m311
Pull 3.11 Diff URL:
https://github.com/sammarshallou/moodle/compare/MOODLE_311_STABLE...MDL-71559-m311
Pull Main Branch:
~~MDL-71559~~-master
Pull Main Diff URL:
https://github.com/sammarshallou/moodle/compare/master...MDL-71559-master
Testing Instructions:
Hide

Ensure that the debugging and debug display options are enabled

Create a 'text input' profile field with max length < 255 using the 'Visible to user, teachers and admins' option.

Select this using the 'show user identity' option (Users / Permissions / User policies).

Look at the participants page for a course

EXPECTED: PHP warnings like the below should not display:

Notice: Undefined variable: allowed in [my moodle path]\user\classes\fields.php on line 389
Show
Ensure that the debugging and debug display options are enabled Create a 'text input' profile field with max length < 255 using the 'Visible to user, teachers and admins' option. Select this using the 'show user identity' option (Users / Permissions / User policies). Look at the participants page for a course EXPECTED: PHP warnings like the below should not display: Notice: Undefined variable: allowed in [my moodle path] \user\classes\fields.php on line 389

Description

The new PROFILE_VISIBLE_TEACHERS constant was added recently (~~MDL-28452~~). This constant is not supported in the new \core_user\fields API.

To reproduce:

Create a 'text input' profile field with max length < 255 using the 'visible to teachers' option.
Select this using the 'show user identity' option (Users / Permissions / User policies).
Look at the participants page for a course

You then get PHP warnings:

Notice: Undefined variable: allowed in [my moodle path]\user\classes\fields.php on line 389

Attachments

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-71559.jpg
36 kB
10/Jun/21 1:02 PM

Activity

People

Assignee:: Sam Marshall

Reporter:: Sam Marshall

Peer reviewer:: Katie Ransom

Integrator:: Andrew Lyons

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, Jonas Lanz, Katie Ransom, Peter Diedrichs, Sam Marshall

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 07/May/21 12:01 AM

Updated:: 10/Sep/21 3:14 PM

Resolved:: 11/Jun/21 2:44 PM

Fix Release Date:: 12/Jul/21

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

1h 40m