Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71568

Calendar allows action_events to be moved when they shouldn't be

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.8.8, 3.10.3, 3.11
    • Fix Version/s: None
    • Component/s: Assignment, Calendar
    • Labels:
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_38_STABLE

      Description

      We have a mod_assign submission plugin that generates a calendar event linked to the assignment instance.

      It appears that on the calendar view this can be moved via drag & drop because the mod_assign functions that report whether or not an assignment action event can be moved returns a [null, null] response if the eventtype is not one of the built-in Moodle event types.

      The calendar API itself seems to expect that the response be, either boolean values or integer values (see calendar/classes/local/api.php update_event_start_day() ). 

      Check for whether or not the event is movable is based on either $min or $max being "=== false" and "null" doesn't satisfy this condition.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            mhughes2k Michael Hughes
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 minutes
                5m