[MDL-71619] Privacy provider tests can cause failures when extending incorrect testcase class - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.7, 3.10.4, 3.11, 4.0
Fix Version/s: 3.10.5, 3.11.1
Component/s: Privacy
Labels:
- CatalystIT
- ci
- partner

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 3.11 Branch:
~~MDL-71619~~-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...paulholden:MDL-71619-311
Pull Master Branch:
~~MDL-71619~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-71619

Testing Instructions:

Hide

1. Run each affected testsuite immediately prior to tool_dataprivacy_testsuite, aka, run:

vendor/bin/phpunit --stop-on-failure --testsuite mod_assignment_testcase,tool_dataprivacy_testsuite && \

vendor/bin/phpunit --stop-on-failure --testsuite quizaccess_seb_testsuite,tool_dataprivacy_testsuite && \

vendor/bin/phpunit --stop-on-failure --testsuite mod_workshop_testsuite,tool_dataprivacy_testsuite && \

vendor/bin/phpunit --stop-on-failure --testsuite workshopform_accumulative_testsuite,tool_dataprivacy_testsuite && \

vendor/bin/phpunit --stop-on-failure --testsuite workshopform_comments_testsuite,tool_dataprivacy_testsuite && \

vendor/bin/phpunit --stop-on-failure --testsuite workshopform_numerrors_testsuite,tool_dataprivacy_testsuite && \

vendor/bin/phpunit --stop-on-failure --testsuite workshopform_rubric_testsuite,tool_dataprivacy_testsuite && \

vendor/bin/phpunit --stop-on-failure --testsuite report_stats_testsuite,tool_dataprivacy_testsuite &&

echo "All OK!"

2. Verify that the executions end ok, with "All OK!" message at the end.

Show

1. Run each affected testsuite immediately prior to tool_dataprivacy_testsuite , aka, run: vendor/bin/phpunit --stop-on-failure --testsuite mod_assignment_testcase,tool_dataprivacy_testsuite && \ vendor/bin/phpunit --stop-on-failure --testsuite quizaccess_seb_testsuite,tool_dataprivacy_testsuite && \ vendor/bin/phpunit --stop-on-failure --testsuite mod_workshop_testsuite,tool_dataprivacy_testsuite && \ vendor/bin/phpunit --stop-on-failure --testsuite workshopform_accumulative_testsuite,tool_dataprivacy_testsuite && \ vendor/bin/phpunit --stop-on-failure --testsuite workshopform_comments_testsuite,tool_dataprivacy_testsuite && \ vendor/bin/phpunit --stop-on-failure --testsuite workshopform_numerrors_testsuite,tool_dataprivacy_testsuite && \ vendor/bin/phpunit --stop-on-failure --testsuite workshopform_rubric_testsuite,tool_dataprivacy_testsuite && \ vendor/bin/phpunit --stop-on-failure --testsuite report_stats_testsuite,tool_dataprivacy_testsuite && echo "All OK!" 2. Verify that the executions end ok, with " All OK! " message at the end.

Description

Affected testsuites all produce variations of the following when they don't extend the core_privacy\tests\provider_testcase, because they don't reset the request writer during tearDown as that class does: https://github.com/moodle/moodle/blob/3da88a7664c7cd9df39465259b4d2fadb504f3d1/privacy/classes/tests/provider_testcase.php#L42

$ vendor/bin/phpunit --stop-on-failure --testsuite report_stats_testsuite,tool_dataprivacy_testsuite

Moodle 4.0dev (Build: 20210507)

Php: 7.3.28.1.16.04.1.1, mysqli: 5.7.33-0ubuntu0.16.04.1, OS: Linux 4.15.0-142-generic x86_64

PHPUnit 9.5.2 by Sebastian Bergmann and contributors.

...............................................................  63 / 317 ( 19%)

............................................................... 126 / 317 ( 39%)

............................................................... 189 / 317 ( 59%)

.............................................E

Time: 01:08.144, Memory: 111.00 MB

There was 1 error:

1) tool_dataprivacy_expired_data_requests_testcase::test_data_request_expiry

file_exception: Cannot read file. Either the file does not exist or there is a permission problem. (mock_path)

/mnt/export/moodle/master/src/lib/filestorage/file_system.php:475

/mnt/export/moodle/master/src/lib/filestorage/file_system_filedir.php:348

/mnt/export/moodle/master/src/lib/filestorage/file_storage.php:1829

/mnt/export/moodle/master/src/lib/filestorage/file_storage.php:1358

/mnt/export/moodle/master/src/admin/tool/dataprivacy/classes/task/process_data_request_task.php:128

/mnt/export/moodle/master/src/lib/phpunit/classes/advanced_testcase.php:738

/mnt/export/moodle/master/src/admin/tool/dataprivacy/tests/expired_data_requests_test.php:81

/mnt/export/moodle/master/src/lib/phpunit/classes/advanced_testcase.php:80

ERRORS!

Tests: 235, Assertions: 975, Errors: 1.

This was reported by a partner (in WP-2665) regarding some Workplace plugins - there are various instances in Moodle too

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-71619-310.png
3 kB
20/May/21 1:00 PM
MDL-71619-311.png
3 kB
20/May/21 1:00 PM
MDL-71619-master.png
3 kB
20/May/21 1:00 PM

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Dmitrii Metelkin

Integrator:: Eloy Lafuente (stronk7)

Tester:: Michael Hawkins

Participants:: Andrew Lyons, CiBoT, Dmitrii Metelkin, Eloy Lafuente (stronk7), Michael Hawkins, Paul Holden

Component watchers:: Andrew Lyons, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 13/May/21 6:49 PM

Updated:: 20/May/21 6:01 PM

Resolved:: 20/May/21 6:01 PM

Fix Release Date:: 12/Jul/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged: