Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-7167

Kill all uses of sql_paging_limit()

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7
    • Component/s: Database SQL/XMLDB
    • Labels:
      None
    • Environment:
      Any DB
    • Database:
      Any
    • Affected Branches:
      MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE

      Description

      sql_paging_limit() is deprecated in 1.7 all all its uses must be out completely from core in order to guarantee cross-db queries. Current uses are:

      blocks/glossary_random/block_glossary_random.php: $LIMIT = sql_paging_limit($i-1, 1);
      blocks/glossary_random/block_glossary_random.php: $LIMIT = sql_paging_limit($i-1, 1);
      blocks/online_users/block_online_users.php: $groupselect ".sql_paging_limit(0,20);
      blog/lib.php: $limit = sql_paging_limit($fetchstart, $fetchlimit);
      course/report/participation/index.php: $sql .= ' '.sql_paging_limit($table->get_page_start(), $table->get_page_size());
      enrol/authorize/locallib.php: $limit = ' ' . sql_paging_limit($table->get_page_start(), $table->get_page_size());
      lib/datalib.php: $limit = sql_paging_limit($page, $recordsperpage);
      lib/datalib.php: $limit = sql_paging_limit($limitfrom, $limitnum);
      lib/datalib.php: $limit = sql_paging_limit($page, $recordsperpage);
      mod/assignment/lib.php: $limit = sql_paging_limit($offset+1, 1);
      mod/assignment/lib.php: $limit = ' '.sql_paging_limit($table->get_page_start(), $table->get_page_size());

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Tester:
              Nobody
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                7/Nov/06