Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71694

Grade validation failure causes loss of feedback comments

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Behat test already covers this, but for clarity:

      1. Create a course with an assignment activity
      2. Make sure 'Feedback comments' are enabled for this activity
      3. Grade a student's work
      4. Enter an impossible grade (e.g. 101 out of 100)
      5. Enter a feedback comment
      6. Press "Save changes"
      7. Confirm that the feedback comment is still visible (as well as the validation error for the grade)
      Show
      Behat test already covers this, but for clarity: Create a course with an assignment activity Make sure 'Feedback comments' are enabled for this activity Grade a student's work Enter an impossible grade (e.g. 101 out of 100) Enter a feedback comment Press "Save changes" Confirm that the feedback comment is still visible (as well as the validation error for the grade)
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-71694-master

      Description

      Steps to reproduce:
      1. Create an assignment with: "Grading method" = "Rubric" and "Feedback comments" enabled
      2. Create a rubric with at least 2 criteria
      3. Grade a student's attempt (does not need to be a real attempt, a blank attempt is fine)
      4. Choose a level for one of the rubric critera, but not all of them
      5. Enter a comment in the "Feedback comments" section
      6. Press "Save changes"

      Expected result:
      1. Rubric displays "Please choose something for each criterion"
      2. Previously entered feedback comments are displayed

      Actual result:
      1. Rubric displays "Please choose something for each criterion"
      2. Feedback comments are now blank - the previously entered comment has been lost

        Attachments

          Activity

            People

            Assignee:
            tonybutler Tony Butler
            Reporter:
            davosmith Davo Smith
            Peer reviewer:
            Davo Smith Davo Smith
            Integrator:
            Andrew Lyons Andrew Lyons
            Tester:
            CiBoT CiBoT
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Jul/21

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 35 minutes
                35m