[MDL-71694] Grade validation failure causes loss of feedback comments - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.7, 3.10.4, 3.11
Fix Version/s: 3.10.5, 3.11.1
Component/s: Assignment
Labels:
- ci
- partner
- patch
- release_notes
- synergy-learning
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE
Pull from Repository:
https://github.com/lucisgit/moodle
Pull Master Branch:
~~MDL-71694~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...lucisgit:MDL-71694-master
Testing Instructions:
Hide

Behat test already covers this, but for clarity:

Create a course with an assignment activity

Make sure 'Feedback comments' are enabled for this activity

Grade a student's work

Enter an impossible grade (e.g. 101 out of 100)

Enter a feedback comment

Press "Save changes"

Confirm that the feedback comment is still visible (as well as the validation error for the grade)
Show
Behat test already covers this, but for clarity: Create a course with an assignment activity Make sure 'Feedback comments' are enabled for this activity Grade a student's work Enter an impossible grade (e.g. 101 out of 100) Enter a feedback comment Press "Save changes" Confirm that the feedback comment is still visible (as well as the validation error for the grade)

Description

Steps to reproduce:
1. Create an assignment with: "Grading method" = "Rubric" and "Feedback comments" enabled
2. Create a rubric with at least 2 criteria
3. Grade a student's attempt (does not need to be a real attempt, a blank attempt is fine)
4. Choose a level for one of the rubric critera, but not all of them
5. Enter a comment in the "Feedback comments" section
6. Press "Save changes"

Expected result:
1. Rubric displays "Please choose something for each criterion"
2. Previously entered feedback comments are displayed

Actual result:
1. Rubric displays "Please choose something for each criterion"
2. Feedback comments are now blank - the previously entered comment has been lost

Attachments

Activity

People

Assignee:: Tony Butler

Reporter:: Davo Smith

Peer reviewer:: Davo Smith

Integrator:: Andrew Lyons

Tester:: CiBoT

Participants:: Adrian Greeve, Andrew Lyons, CiBoT, Davo Smith, Eloy Lafuente (stronk7), Tony Butler

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 20/May/21 8:19 PM

Updated:: 05/Jul/21 11:10 AM

Resolved:: 25/Jun/21 5:39 AM

Fix Release Date:: 12/Jul/21

Time Tracking

Estimated:

Remaining:

Logged:

35m