[MDL-71789] Add mform validation for invalid url when importing a calendar - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.0
Fix Version/s: 3.10.5, 3.11.1
Component/s: Calendar
Labels:

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE
Epic Link:
Calendar usability improvements for 4.0
Pull from Repository:
git://github.com/lameze/moodle.git
Pull Master Branch:
~~MDL-71789~~-master
Pull Master Diff URL:
https://github.com/lameze/moodle/compare/338b60f43b...MDL-71789-master
Testing Instructions:
Hide

Log in as admin and go to Calendar > Manage subscriptions.

On the Import calendar form, add a calendar name and click Add.

Make sure the Calendar URL field displays "The given iCal URL is invalid." validation.

On the Calendar URL field, add any text and click Add

Make sure the Calendar URL field displays "The given iCal URL is invalid." validation.

Now, add a valid URL to the Calendar URL field and click Add:

https://calendar.google.com/calendar/ical/moodle.com_gverd91agb5htmi8ervnn6q2j0%40group.calendar.google.com/public/basic.ics

Make sure the calendar has been added.
Show
Log in as admin and go to Calendar > Manage subscriptions. On the Import calendar form, add a calendar name and click Add . Make sure the Calendar URL field displays "The given iCal URL is invalid." validation. On the Calendar URL field, add any text and click Add Make sure the Calendar URL field displays "The given iCal URL is invalid." validation. Now, add a valid URL to the Calendar URL field and click Add : https://calendar.google.com/calendar/ical/moodle.com_gverd91agb5htmi8ervnn6q2j0%40group.calendar.google.com/public/basic.ics Make sure the calendar has been added.

Story Points:
1
Sprint:
HQ Team International Sprint 3

Description

Current behaviour: When trying to import a calendar with an invalid url an error message is displayed.

Proposed change: Add a mform validation to prevent the error message from being displayed. Surely this can be backported to stables.

Attachments

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-71789_Test Passed.png
87 kB
01/Jul/21 1:43 PM

Issue Links

will help resolve

MDL-69282 Calendar allows to import from itself

Reopened

Activity

People

Assignee:: Simey Lameze

Reporter:: Simey Lameze

Peer reviewer:: Dongsheng Cai

Integrator:: Sara Arjona (@sarjona)

Tester:: Gladys Basiana

Participants:: CiBoT, Dongsheng Cai, Gladys Basiana, Sara Arjona (@sarjona), Simey Lameze

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 28/May/21 8:43 AM

Updated:: 13/Apr/22 1:57 AM

Resolved:: 01/Jul/21 11:46 PM

Fix Release Date:: 12/Jul/21

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

2h 36m