Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
3.11
-
0
-
HQ Team International Sprint 2, HQ Team International Sprint 3, HQ Team International Sprint 4
Description
1. create a SCORM activity
2. in settings->"Activity completion" check both "passed" and "completed" conditions
3. run the SCORM and get the "passed" (OR "completed") status from LO
EXPECTED RESULT: activity marked as "complete"
WHAT HAPPENS: activity is still to be "completed".
-
from the help in scorm settings->Activity completion->Require status:
"Checking one or more statuses will require a user to achieve at least one of the checked statuses in order to be marked complete in this SCORM activity, as well as any other Activity Completion requirements"
please, note: "...at least one of the checked statuses in order to be marked complete".
that is correct, speaking of SCORM objects. and working fine until moodle 3.10.
no longer working on moodle 3.11, despite what the "help" states.
case 1:
passed checked
case 2:
completed checked
case 3:
passed AND completed checked
in
mod/scorm/classes/completion/custom_completion.php
you can see:
$requiredcompletionstatusid = $this->cm->customdata['customcompletionrules']['completionstatusrequired'] ?? 0;
// Check at least one track meets the required completion status value(s).
foreach ($tracks as $track) {
if (array_key_exists($track->value, $statuses))
// All completion status requirements met.
if ($statusbits == $requiredcompletionstatusid)
}
if you have checked both conditions "completed" and "passed", $requiredcompletionstatusid equals to "6".
but a student will never have both "completed" and "passed" tracks, therefore $statusbits will be 2 OR 4, never 6. consequently, $status will be never set to COMPLETION_COMPLETE
if this is not a bug, then lot of people will have lot of troubles, having to re-set "Activity completion" for (possibly) hundred of SCORMs
regards.
Attachments
Issue Links
- is a regression caused by
-
MDL-70935 Implement the completion details functionality for each activity plugins output them in view.php - Part 2
-
- Closed
-