Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71876

Failures with Firefox on H5P essay report scenario (take #2)

    XMLWordPrintable

    Details

      Description

      We have started to get this failure recently (< 24h ago), consistently... and only affecting to 310_STABLE, exclusively with Firefox.

      $ br --profile firefox --suite default --name 'View attempt essay content'
       
      Command: vendor/bin/behat --config /Users/stronk7/Sites/moodle_data_gitintegration/MOODLE_310_STABLE/postgres_behat/behatrun/behat/behat.yml  --profile firefox --suite default --name 'View attempt essay content'
       
      Moodle 3.10.4+ (Build: 20210604), 2d7386420cb8828fafb3cafebcec8fdae37d4188
      Php: 7.4.16, pgsql: 9.6.21, OS: Darwin 20.5.0 x86_64
      Run optional tests:
      - Accessibility: No
      Server OS "Darwin", Browser: "firefox"
      Started at 09-06-2021, 06:18
      ....................F---
       
      --- Pasos fallidos:
       
      001 Scenario: View attempt essay content # /Users/stronk7/git_moodle/integration/mod/h5pactivity/tests/behat/result_longfillin.feature:31
            When I follow "View my attempts"   # /Users/stronk7/git_moodle/integration/mod/h5pactivity/tests/behat/result_longfillin.feature:43
              Link matching locator "View my attempts" not found. (Behat\Mink\Exception\ElementNotFoundException)
       
      1 escenario (1 fallaron)
      24 pasos (20 pasaron, 1 fallaron, 3 saltadas)
      0m57.60s (56.85Mb)
      

      The failure sounded a lot to me and lookin in the tracker MDL-71337 has been found, with a trivial solution that fixed the problem there.

      Also, it has been confirmed that the scenario has started to fail with latest Firefox 89 selenium docker image update that happened <24h ago. It was working ok with previous versions. Sure it's one of those 1-pixel differences that is not striking us.

      So, there are 2 possible solutions:

      a) Or we make the selenium firefox image stick @ CI infrastructure.
      b) Or we backport the fix applied in the original issue.

      Trying b) I've tested it here and it makes the test to pass:

      $ git pk 18ad675
      [MOODLE_310_STABLE 77cc3a80247] MDL-71337 mod_h5pactivity: Increase window size during test
       
      $ br --profile firefox --suite default --name 'View attempt essay content'
       
      Command: vendor/bin/behat --config /Users/stronk7/Sites/moodle_data_gitintegration/MOODLE_310_STABLE/postgres_behat/behatrun/behat/behat.yml  --profile firefox --suite default --name 'View attempt essay content'
       
      Moodle 3.10.4+ (Build: 20210604), 77cc3a80247d06636f6d15b540c87cef1ff4003e
      Php: 7.4.16, pgsql: 9.6.21, OS: Darwin 20.5.0 x86_64
      Run optional tests:
      - Accessibility: No
      Server OS "Darwin", Browser: "firefox"
      Started at 09-06-2021, 06:27
      .........................
       
      1 escenario (1 pasaron)
      25 pasos (25 pasaron)
      0m49.96s (56.85Mb)
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Carlos Escobedo Carlos Escobedo
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              CiBoT CiBoT
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jul/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 25 minutes
                  1h 25m