Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.9.11, 3.10.8, 3.11.4, 4.0
Description
If a third-party JS module is included and it already has a named define, then we should replace that name rather than trying to add to it (which we currently do).
The signature for the define call is:
define = function (name, deps, callback) {
|
https://github.com/requirejs/requirejs/blob/master/require.js#L2061
We can easily replace any provided name with the calculated one. We know it will always be a String if provided (it's optional). We already perform AST translations so this should be trivial.
Attachments
Issue Links
- has been marked as being related by
-
MDL-66107 Stop bundling all files in first.js
-
- Reopened
-