Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71884

Dropdown menus use old code, can sometimes get cut-off on right.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.11
    • Fix Version/s: None
    • Component/s: Accessibility, Messages, Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_311_STABLE

      Description

      There's some dropdown menus within messaging trigerred from an ellipsis icon in the top right.

      When you click them, they drop down, and the JS we use tries to automatically position them based on available space and hints given in the code as to what we'd prefer for that dropdown.

      Some have some old code, using pull-right or float-right, when they probably should use dropdown-menu-right to get the menu to line up to the right of the button trigger.

      In certain weird circumstances, the JS gets confused and the menu is positioned partly off the screen, sometimes it slowly slides back onto the screen eventually. I believe this is the JS doing it's best to position the menu so that it lines up on the left and sometimes getting it wrong. We should use the correct class to tell it to line up on the right hand side for these dropdowns, which solves this problem and makes life easier for the JS library.

      templates/message_drawer_view_conversation_header_content_type_private.mustache
      86: <div id="conversation-actions-menu" class="dropdown-menu float-right" role="menu"

       

      templates/message_drawer_view_conversation_header_content_type_public.mustache
      80: <div id="conversation-actions-menu" class="dropdown-menu float-right" role="menu"

      templates/message_drawer_view_conversation_header_content_type_self.mustache
      79: <div class="dropdown-menu pull-right">

       

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            bawjaws David Scotson
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Huong Nguyen, Bas Brands, Mathew May
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated: