Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71885

Inline editing H5P content for mod_h5pactivity

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Covered mostly by unit tests. However, the following tests should be executed manually, to guarantee the edit form can be accessed only by users with the expected permissions:

      Setup

      1. Login as admin.
      2. Go to "Site administration > H5P > Manage H5P content types" and upload the attached H5P into the "H5P content type" field.
      3. Create a course (Course1).
      4. Enrol t1 user as a teacher in Course1.  

      Testing instructions

      1. Login as teacher1.
      2. Access to Private files and upload the attached H5P file.
      3. Access to Course1.
      4. Create an H5P activity. Select the Private file uploaded previously and add it as a "Link to the file".
      5. Save and display.
      6. Check the "Edit H5P content" button is displayed below the H5P player.
      7. Copy the URL in the "Edit H5P content" button.
      8. Click the "Edit H5P content" button.
      9. Check the H5P editor is displayed.
      10. Logout
      11. Login as admin
      12. Go to the Course1 and access to the H5P activity.
      13. Check the "Edit H5P content" button is not displayed.
      14. Paste the URL copied in step #6.
      15. Check the following error is displayed: "The given URL is incorrect or you cannot edit this file.".
      Show
      Covered mostly by unit tests. However, the following tests should be executed manually, to guarantee the edit form can be accessed only by users with the expected permissions: Setup Login as admin. Go to "Site administration > H5P > Manage H5P content types" and upload the attached H5P into the "H5P content type" field. Create a course (Course1). Enrol t1 user as a teacher in Course1.   Testing instructions Login as teacher1. Access to Private files and upload the attached H5P file. Access to Course1. Create an H5P activity. Select the Private file uploaded previously and add it as a "Link to the file". Save and display. Check the "Edit H5P content" button is displayed below the H5P player. Copy the URL in the "Edit H5P content" button. Click the "Edit H5P content" button. Check the H5P editor is displayed. Logout Login as admin Go to the Course1 and access to the H5P activity. Check the "Edit H5P content" button is not displayed. Paste the URL copied in step #6. Check the following error is displayed: "The given URL is incorrect or you cannot edit this file.".
    • Affected Branches:
      MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-71885-master
    • Sprint:
      Moppies Kanban

      Description

      Add a button to let users (with the expected permissions) inline editing H5P content using the editor but without having to upload/create files into the content bank.

       

      Acceptance criteria:

      • If the file is a link to another file, the edited file will be the source. In that case, a notice saying "This content may be in use in other places" should be displayed.
      • Users can edit H5P content in the following situations (the idea is to make it consistent with current edit behaviour: if a user can edit the content where this H5P belongs, he will be able to edit it too, if he has access to the file, of course):
        • If it is a private file and they are the authors OR
        • If it's a file belonging to mod_h5pactivity, if they have the addinstance capability OR
        • If it's an H5P content bank file and they can edit it (through the content bank).

       
       

        Attachments

        1. arithmetic-quiz.h5p
          731 kB
        2. contentbankrepository.png
          contentbankrepository.png
          62 kB
        3. edith5pinline.png
          edith5pinline.png
          57 kB
        4. editorcb.png
          editorcb.png
          57 kB
        5. h5peditor.png
          h5peditor.png
          44 kB
        6. image-2021-06-21-11-01-49-392.png
          image-2021-06-21-11-01-49-392.png
          34 kB
        7. MDL-71885_step8.jpg
          MDL-71885_step8.jpg
          17 kB
        8. MDL-71885.jpg
          MDL-71885.jpg
          39 kB

          Issue Links

            Activity

              People

              Assignee:
              sarjona Sara Arjona (@sarjona)
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Peer reviewer:
              Carlos Escobedo Carlos Escobedo
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Dec/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 days, 5 hours, 5 minutes
                  4d 5h 5m