Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71909

editpdf feedback setting in assign not respected

XMLWordPrintable

    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-71909-m401
    • MDL-71909-m402
    • Hide

      The change is covered by unit tests.

      There was already one to check that documents were queued, this change adds one to check that they are not when the plugin is not selected on an assignment.

      For a manual test you could do the following:

      You will need:

      • a file you can use for submissions
      • a course that has an editing teacher and at least one student enrolled on it

      Documents not queued when assignment feedback is not on for assignment

      1. On the command line run: 

        sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php  --classname=\\assignfeedback_editpdf\\task\\convert_submission

      2. Navigate to the course as the editing teacher
      3. Create an assignment with the following settings:
        1. Submission types: File submissions
        2. Feedback types: Feedback comments
        3. Verify that the Annotate PDF Feedback type is not checked
      4. In the assignment click the View all submissions button
      5. Open the Edit menu for a student and select Edit submission
      6. Upload your file and save
      7. On the command line run: 

        sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php  --classname=\\assignfeedback_editpdf\\task\\convert_submission

      8. Verify that no tasks are run

      Documents are queued when assignment feedback is on for assignment

      1. On the command line run: 

        sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php  --classname=\\assignfeedback_editpdf\\task\\convert_submission

      2. Navigate to the course as the editing teacher
      3. Create an assignment with the following settings:
        1. Submission types: File submissions
        2. Feedback types: Feedback comments, Annotate PDF
        3. Verify that the Annotate PDF Feedback type is checked
      4. In the assignment click the View all submissions button
      5. Open the Edit menu for a student and select Edit submission
      6. Upload your file and save
      7. On the command line run: 

        sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php  --classname=\\assignfeedback_editpdf\\task\\convert_submission

      8. Verify that 1 task is run

      Documents not queued when assignment feedback plugin is disabled

      1. On the command line run: 

        sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php  --classname=\\assignfeedback_editpdf\\task\\convert_submission

      2. Navigate to the course as the editing teacher
      3. Create an assignment with the following settings:
        1. Submission types: File submissions
        2. Feedback types: Feedback comments, Annotate PDF
        3. Verify that the Annotate PDF Feedback type is checked
      4. Login as the Site administrator
      5. Navigate to Site administration > Plugins > Activity modules > Assignment > Feedback plugins > Manage assignment feedback plugins
      6. Press the eye icon for Annotate PDF
      7. Verify that the eye icon now has a cross through it to indicate the plugin is disabled
      8. Navigate to the assignment
      9. In the assignment click the View all submissions button
      10. Open the Edit menu for a student and select Edit submission
      11. Upload your file and save
      12. On the command line run: 

        sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php  --classname=\\assignfeedback_editpdf\\task\\convert_submission

      13. Verify that no tasks are run
      Show
      The change is covered by unit tests. There was already one to check that documents were queued, this change adds one to check that they are not when the plugin is not selected on an assignment. For a manual test you could do the following: You will need: a file you can use for submissions a course that has an editing teacher and at least one student enrolled on it Documents not queued when assignment feedback is not on for assignment On the command line run: sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php --classname=\\assignfeedback_editpdf\\task\\convert_submission Navigate to the course as the editing teacher Create an assignment with the following settings: Submission types: File submissions Feedback types: Feedback comments Verify that the Annotate PDF Feedback type is not checked In the assignment click the View all submissions button Open the Edit menu for a student and select Edit submission Upload your file and save On the command line run: sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php --classname=\\assignfeedback_editpdf\\task\\convert_submission Verify that no tasks are run Documents are queued when assignment feedback is on for assignment On the command line run: sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php --classname=\\assignfeedback_editpdf\\task\\convert_submission Navigate to the course as the editing teacher Create an assignment with the following settings: Submission types: File submissions Feedback types: Feedback comments, Annotate PDF Verify that the Annotate PDF Feedback type is checked In the assignment click the View all submissions button Open the Edit menu for a student and select Edit submission Upload your file and save On the command line run: sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php --classname=\\assignfeedback_editpdf\\task\\convert_submission Verify that 1 task is run Documents not queued when assignment feedback plugin is disabled On the command line run: sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php --classname=\\assignfeedback_editpdf\\task\\convert_submission Navigate to the course as the editing teacher Create an assignment with the following settings: Submission types: File submissions Feedback types: Feedback comments, Annotate PDF Verify that the Annotate PDF Feedback type is checked Login as the Site administrator Navigate to Site administration > Plugins > Activity modules > Assignment > Feedback plugins > Manage assignment feedback plugins Press the eye icon for Annotate PDF Verify that the eye icon now has a cross through it to indicate the plugin is disabled Navigate to the assignment In the assignment click the View all submissions button Open the Edit menu for a student and select Edit submission Upload your file and save On the command line run: sudo -u www-data /usr/bin/php admin/cli/adhoc_task.php --classname=\\assignfeedback_editpdf\\task\\convert_submission Verify that no tasks are run

      Even if editpdf feedback type is unset in a new assignment, all files uploaded are added to assignfeedback_editpdf_queue and converted when task assignfeedback_editpdf\task\convert_submissions launched

      environment

      • Debian 10 / php 7.3 / mariadb 10.3
      • unoconv 0.7 / ghostscript 9.27
      • Moodle 3.10.4

      step to reproduce

      1. on a fresh Moodle install, all settings to default
      2. create a user and a course
      3. in  course, create an assignment and unset editpdf feedback
      4. enroll created user as student
      5. connect as student, go in course/assignment and upload an odt file
      6. confirm table mdl_assignfeedback_editpdf_queue have one record

      Same behaviour in our 3.8 production environment. From files table, with

      select component, count, sum(filesize)/1024/1024 as sizeMo from mdl_files group by component order by sizeMo desc;

      whe can see that :

      • more than 80% of files are in «assignfeedback_editpdf» area
      • files in «assignfeedback_editpdf» area represent 60% of total size of all files
      • less than 5% of our assignments activities are configured with editpdf feedback

        1. (I) Passed -- (Master)MDL-71909.png
          (I) Passed -- (Master)MDL-71909.png
          112 kB
        2. (II) Passed -- (Master)MDL-71909.png
          (II) Passed -- (Master)MDL-71909.png
          55 kB
        3. (III) Passed -- (Master)MDL-71909.png
          (III) Passed -- (Master)MDL-71909.png
          116 kB
        4. delete_unused_files.php
          1 kB
        5. MDL-71909-400.patch
          1 kB
        6. Moodle Upgrade.png
          Moodle Upgrade.png
          16 kB

            Votes:
            38 Vote for this issue
            Watchers:
            46 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 2 hours
                2d 2h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.