Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71926

Add an activity or resource link always visible in 3.11+

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing:

      1. Log in as an admin
      2. Create a new course
      3. Enrol a student and a teacher into the course
      4. On the 'site home' with editing on
      5. Create a label - content doesn't matter.
      6. Log out
      7. Go to the Site home
      8. Confirm there is no 'Add an activity or resource' link available
      9. Login as the teacher
      10. View the course
      11. Confirm there are no 'Add an activity or resource' links available
      12. Turn on editing
      13. Confirm there are 'Add an activity or resource' links available
      14. Login as a student
      15. View the course
      16. Confirm there are no 'Add an activity or resource' links available
      Show
      Testing: Log in as an admin Create a new course Enrol a student and a teacher into the course On the 'site home' with editing on Create a label - content doesn't matter. Log out Go to the Site home Confirm there is no 'Add an activity or resource' link available Login as the teacher View the course Confirm there are no 'Add an activity or resource' links available Turn on editing Confirm there are 'Add an activity or resource' links available Login as a student View the course Confirm there are no 'Add an activity or resource' links available
    • Affected Branches:
      MOODLE_311_STABLE
    • Fixed Branches:
      MOODLE_311_STABLE
    • Pull from Repository:
    • Pull 3.11 Branch:
      MDL-71926-311
    • Pull Master Branch:
      MDL-71926-master

      Description

      As reported in the Moodle.org forums in English and Spanish, since the 3.11+ upgrade of 11 June, students see the link "Add an activity or resource" and teachers see it without the editing being turned on. When they click it they see an empy activity chooser, but they should not be seeing anything at all.

      Also, note that the "Add an activity or resource" links are shown no matter edition is turned on or off. Only should be available for "teachers" and on edition mode.

      Edited, there is a proposed patch @ moodle.org's forums: https://moodle.org/mod/forum/discuss.php?d=423427#p1705918

      Note: This issue only affects 311 as master has already moved on from this, but the patch should be applied to both to allow contributed course formats to function correctly.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              marycooch Mary Cooch
              Peer reviewer:
              Mihail Geshoski Mihail Geshoski
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              5 Vote for this issue
              Watchers:
              14 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jul/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 5 minutes
                  2h 5m