[MDL-71926] Add an activity or resource link always visible in 3.11+ - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.11
Fix Version/s: 3.11.1
Component/s: Course
Labels:
- ci
- regression
- release_notes
- triaged

Affected Branches:
MOODLE_311_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
git://github.com/peterRd/moodle.git
Pull 3.11 Branch:
~~MDL-71926~~-311
Pull 3.11 Diff URL:
https://github.com/peterRd/moodle/compare/70f99ddd9a...MDL-71926-311
Pull Master Branch:
~~MDL-71926~~-master
Pull Master Diff URL:
https://github.com/peterRd/moodle/compare/9533e8ddf5...MDL-71926-master
Testing Instructions:
Hide

Testing:

Log in as an admin

Create a new course

Enrol a student and a teacher into the course

On the 'site home' with editing on

Create a label - content doesn't matter.

Log out

Go to the Site home

Confirm there is no 'Add an activity or resource' link available

Login as the teacher

View the course

Confirm there are no 'Add an activity or resource' links available

Turn on editing

Confirm there are 'Add an activity or resource' links available

Login as a student

View the course

Confirm there are no 'Add an activity or resource' links available
Show
Testing: Log in as an admin Create a new course Enrol a student and a teacher into the course On the 'site home' with editing on Create a label - content doesn't matter. Log out Go to the Site home Confirm there is no 'Add an activity or resource' link available Login as the teacher View the course Confirm there are no 'Add an activity or resource' links available Turn on editing Confirm there are 'Add an activity or resource' links available Login as a student View the course Confirm there are no 'Add an activity or resource' links available

Description

As reported in the Moodle.org forums in English and Spanish, since the 3.11+ upgrade of 11 June, students see the link "Add an activity or resource" and teachers see it without the editing being turned on. When they click it they see an empy activity chooser, but they should not be seeing anything at all.

Also, note that the "Add an activity or resource" links are shown no matter edition is turned on or off. Only should be available for "teachers" and on edition mode.

Edited, there is a proposed patch @ moodle.org's forums: https://moodle.org/mod/forum/discuss.php?d=423427#p1705918

Note: This issue only affects 311 as master has already moved on from this, but the patch should be applied to both to allow contributed course formats to function correctly.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-71926_Test Passed.png
232 kB
17/Jun/21 3:39 PM

Issue Links

is a regression caused by

MDL-71682 Main Menu block non-js dropdowns are deprecated error

Closed

is duplicated by

MDL-71936 Displaying 'Add an activity or resource' link on site home before login!

Closed

Activity

People

Assignee:: Peter Dias

Reporter:: Mary Cooch

Peer reviewer:: Mihail Geshoski

Integrator:: Andrew Lyons

Tester:: Gladys Basiana

Participants:: Admin CEW, Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Gladys Basiana, Mary Cooch, Mihail Geshoski, Peter Dias, Rick Jerz, Vadim Tabunshchik

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 5 Vote for this issue

Watchers:: 14 Start watching this issue

Dates

Created:: 15/Jun/21 1:58 AM

Updated:: 17/Jun/21 11:35 PM

Resolved:: 17/Jun/21 11:35 PM

Fix Release Date:: 12/Jul/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 5m