Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-7193

select_color.php popup should specify charset

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.6.2
    • 1.6.4, 1.7, 1.8
    • HTML Editor (TinyMCE)
    • None
    • non Latin1 env. (esp. ja)
    • MOODLE_16_STABLE
    • MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE

    Description

      lib/editor/htmlarea/popups/select_color.php does not specify its charset using a meta tag. This causes IE (and maybe other browsers) confusing character encoding in non-latin1 environment.

      A possible fix is:

      — select_color.php.orig Tue Oct 24 19:31:46 2006
      +++ select_color.php Tue Oct 24 17:43:33 2006
      @@ -1,8 +1,11 @@
      <?php
      include("../../../../config.php");
      ?>
      +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
      + "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
      <html>
      <head>
      +<meta http-equiv="content-type" content="text/html; charset=<?php print_string("thischarset");?>" />
      <title><?php print_string("selectcolor","editor");?></title>
      <style type="text/css">
      html, body

      { width: 238; height: 188; }

      Attachments

        Activity

          People

            skodak Petr Skoda
            kagotani Hiroto Kagotani
            Nobody Nobody
            Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              7/Nov/06