Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71941

Use new gradenoun/gradeverb strings instead of generic grade strings everywhere

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 4.4
    • 3.11, 4.0.6, 4.1.1, 4.2.2, 4.3
    • Language
    • MOODLE_311_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
    • MOODLE_404_STABLE
    • MDL-71941-master
    • Hide
      1. In language pack modification, change gradenoun to "Grade (noun)" and gradeverb to "Grade (verb)"
      2. As trainer, in a course, go to Grades → View → Single view → Select a grade item
      3. Verify the table header says "Grade (noun)"
      4. As trainer, in a course, go to Grades → View → Single view → Select a user
      5. Verify the table header says "Grade (noun)"
      6. As trainer, in a course, go to Grades → View → User report → Select a user
      7. Verify the table header says "Grade (noun)"
      8. As student, attempt a quiz
      9. Submit the quiz
      10. Review the attempt
      11. Verify the resuming table at the top says "Grade (noun)"
      12. As trainer, go to a quiz where there is a essay question and there are student's attempts
      13. Go to results → Manual grading
      14. Verify the line in the table in the cells under the title "To grade" say "Grade (verb)"
      15. As trainer, go to a quiz where there is a essay question and there are student's attempts
        Review attempts.
      16. In the header table, Verify the grade row title says "Grade (noun)"

      However, by the Behat tests in place an error would prompt if at some spot a deprecated 'grade' string would be called.

      Show
      In language pack modification, change gradenoun to "Grade (noun)" and gradeverb to "Grade (verb)" As trainer, in a course, go to Grades → View → Single view → Select a grade item Verify the table header says "Grade (noun)" As trainer, in a course, go to Grades → View → Single view → Select a user Verify the table header says "Grade (noun)" As trainer, in a course, go to Grades → View → User report → Select a user Verify the table header says "Grade (noun)" As student, attempt a quiz Submit the quiz Review the attempt Verify the resuming table at the top says "Grade (noun)" As trainer, go to a quiz where there is a essay question and there are student's attempts Go to results → Manual grading Verify the line in the table in the cells under the title "To grade" say "Grade (verb)" As trainer, go to a quiz where there is a essay question and there are student's attempts Review attempts. In the header table, Verify the grade row title says "Grade (noun)" However, by the Behat tests in place an error would prompt if at some spot a deprecated 'grade' string would be called.

    Description

      In MDL-71118, some spots went forgotten, that still use 'grade' and not 'gradenoun'/'gradeverb', also do some components maintain their own 'grade' string which isn't consistent and could puzzle users if they override the string in one place but do not see it applied then everywhere.
      This issue lifts those inconsistencies and gets rid of the forgotten occurencies.

      In MDL-71118 new strings "gradenoun" and "gradeverb" were introduced. However, in lesson, quiz and grades there are generic "grade" strings that are used instead and can cause problems. For example in lesson report the "grade" string is used as a noun but in Catalan it's translated as a verb.

      https://github.com/moodle/moodle/blob/master/lang/en/grades.php#L252

      https://github.com/moodle/moodle/blob/master/mod/lesson/lang/en/lesson.php#L246

      https://github.com/moodle/moodle/blob/master/mod/quiz/lang/en/quiz.php#L398

      https://github.com/moodle/moodle/blob/master/mod/quiz/report/grading/lang/en/quiz_grading.php#L41

      Attachments

        1. MDL-71941.png
          MDL-71941.png
          930 kB
        2. not translated.png
          not translated.png
          27 kB
        3. qualifica.png
          qualifica.png
          28 kB
        4. translated.png
          translated.png
          27 kB

        Issue Links

          Activity

            People

              lucaboesch Luca Bösch
              dpalou Dani Palou
              Mathew May Mathew May
              Ilya Tregubov Ilya Tregubov
              Ron Carl Alfon Yu Ron Carl Alfon Yu
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 32 minutes
                  1h 32m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.